[GitHub] [flink] luoyuxia commented on a diff in pull request #20377: [FLINK-27338][hive] Improve splitting file for Hive table with orc format

[GitBox <gi...@apache.org>]

luoyuxia commented on code in PR #20377:
URL: https://github.com/apache/flink/pull/20377#discussion_r1037725058


##########
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveSourceFileEnumerator.java:
##########
@@ -76,10 +98,68 @@ public static List<HiveSourceSplit> createInputSplits(
                 }
             }
         }
-
         return hiveSplits;
     }
 
+    private static boolean supportSetSplitMaxSize(List<HiveTablePartition> partitions) {
+        // now, the configuration 'HiveConf.ConfVars.MAPREDMAXSPLITSIZE' we set only
+        // works for orc format
+        for (HiveTablePartition partition : partitions) {

Review Comment:
   IIRC, the configuration `HiveConf.ConfVars.MAPREDMAXSPLITSIZE` only makes difference  in method `format.getSplits(jobConf, minNumSplits)`  which we delegate to get file splits.
   We can implement our logic to get file splits considering `maxsplitsize`, which should be suitable to all formats,  but currently, we only delegate to Hive's implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org