You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/10 11:44:12 UTC

[GitHub] [arrow] kszucs opened a new pull request #8886: [C++] Add Extend and ExtendMasked to the converter interface

kszucs opened a new pull request #8886:
URL: https://github.com/apache/arrow/pull/8886


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8886: [C++] Add Extend and ExtendMasked to the converter interface

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8886:
URL: https://github.com/apache/arrow/pull/8886#issuecomment-742470961


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   Could you open an issue for this pull request on JIRA?
   https://issues.apache.org/jira/browse/ARROW
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nealrichardson commented on pull request #8886: [C++] Add Extend and ExtendMasked to the converter interface

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8886:
URL: https://github.com/apache/arrow/pull/8886#issuecomment-769943100


   This has been pulled into #8650 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs commented on a change in pull request #8886: [C++] Add Extend and ExtendMasked to the converter interface

Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8886:
URL: https://github.com/apache/arrow/pull/8886#discussion_r540102788



##########
File path: cpp/src/arrow/util/converter.h
##########
@@ -52,7 +52,15 @@ class Converter {
     return Init(pool);
   }
 
-  virtual Status Append(InputType value) = 0;
+  virtual Status Append(InputType value) { return Status::NotImplemented("Append"); }

Review comment:
       @bkietz I think we should keep both `Append` and `Extend` since we wrap the converter object with the `Chunker`, so if one implementation (like the python one) choose to use `Append` then we don't need to subclass the chunker class.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kszucs commented on a change in pull request #8886: [C++] Add Extend and ExtendMasked to the converter interface

Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8886:
URL: https://github.com/apache/arrow/pull/8886#discussion_r540105542



##########
File path: cpp/src/arrow/util/converter.h
##########
@@ -294,6 +302,34 @@ class Chunker {
     return status;
   }
 
+  // we could get bit smarter here since the whole batch of appendable values
+  // will be rejected if a capacity error is raised
+  Status Extend(InputType values, int64_t size) {

Review comment:
       The chunker's extend wrapper is untested since we use `Append` from the python code. Theoretically we can wrap the converter's `Extend` method just like in the case of `Append` though we reject the whole batch rather than a single item.
   
   We could improve this logic but would require details about the iteration.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] romainfrancois commented on a change in pull request #8886: [C++] Add Extend and ExtendMasked to the converter interface

Posted by GitBox <gi...@apache.org>.
romainfrancois commented on a change in pull request #8886:
URL: https://github.com/apache/arrow/pull/8886#discussion_r553176193



##########
File path: cpp/src/arrow/util/converter.h
##########
@@ -294,6 +302,34 @@ class Chunker {
     return status;
   }
 
+  // we could get bit smarter here since the whole batch of appendable values
+  // will be rejected if a capacity error is raised
+  Status Extend(InputType values, int64_t size) {

Review comment:
       I think adding a `int64_t start` in addition to `size` as in #8650 would help. but I haven't yet reviewed how the chunker code works, e.g. can it "know" that it can handle `n` extra values in the current chunk ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] nealrichardson closed pull request #8886: [C++] Add Extend and ExtendMasked to the converter interface

Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #8886:
URL: https://github.com/apache/arrow/pull/8886


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org