You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/05/04 12:33:07 UTC

[GitHub] [activemq-artemis] franz1981 opened a new pull request #3565: ARTEMIS-3280 Netty Pool micrometer metric plugin

franz1981 opened a new pull request #3565:
URL: https://github.com/apache/activemq-artemis/pull/3565


   https://issues.apache.org/jira/browse/ARTEMIS-3280


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] franz1981 commented on pull request #3565: ARTEMIS-3280 Netty Pool micrometer metric plugin

Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3565:
URL: https://github.com/apache/activemq-artemis/pull/3565#issuecomment-831967712


   @jbertram 
   > Are there any Netty docs that we could link to from our docs that explain what these metrics are in more detail?
   yess, on https://netty.io/4.1/api/io/netty/buffer/PooledByteBufAllocatorMetric.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] jbertram commented on pull request #3565: ARTEMIS-3280 Netty Pool micrometer metric plugin

Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3565:
URL: https://github.com/apache/activemq-artemis/pull/3565#issuecomment-849851198


   I went ahead and merged this. We can add corresponding JMX metrics in another PR. Nice work, @franz1981!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] asfgit closed pull request #3565: ARTEMIS-3280 Netty Pool micrometer metric plugin

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3565:
URL: https://github.com/apache/activemq-artemis/pull/3565


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] franz1981 edited a comment on pull request #3565: ARTEMIS-3280 Netty Pool micrometer metric plugin

Posted by GitBox <gi...@apache.org>.
franz1981 edited a comment on pull request #3565:
URL: https://github.com/apache/activemq-artemis/pull/3565#issuecomment-831967712


   @jbertram 
   > Are there any Netty docs that we could link to from our docs that explain what these metrics are in more detail?
   
   yess, on https://netty.io/4.1/api/io/netty/buffer/PooledByteBufAllocatorMetric.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] michaelpearce-gain commented on pull request #3565: ARTEMIS-3280 Netty Pool micrometer metric plugin

Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on pull request #3565:
URL: https://github.com/apache/activemq-artemis/pull/3565#issuecomment-842714395


   I would agree anything metrics wise, we should always seek to ensure its in JMX as then its also visible in admin console.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] franz1981 commented on pull request #3565: ARTEMIS-3280 Netty Pool micrometer metric plugin

Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3565:
URL: https://github.com/apache/activemq-artemis/pull/3565#issuecomment-831909952


   This PR is including the many tiny details exposed by the Netty metrics, but common users will probably just need `netty.pooled.used.memory` of type `direct` and `heap` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] jbertram commented on pull request #3565: ARTEMIS-3280 Netty Pool micrometer metric plugin

Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3565:
URL: https://github.com/apache/activemq-artemis/pull/3565#issuecomment-831959842


   Are there any Netty docs that we could link to from our docs that explain what these metrics are in more detail?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] franz1981 commented on pull request #3565: ARTEMIS-3280 Netty Pool micrometer metric plugin

Posted by GitBox <gi...@apache.org>.
franz1981 commented on pull request #3565:
URL: https://github.com/apache/activemq-artemis/pull/3565#issuecomment-831910317


   @jbertram Do you think it worths to expose `netty.pooled.used.memory` with JMX as well? maybe in a separate PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] jbertram commented on pull request #3565: ARTEMIS-3280 Netty Pool micrometer metric plugin

Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3565:
URL: https://github.com/apache/activemq-artemis/pull/3565#issuecomment-831957851


   @franz1981, for the sake of flexibility it would be good to support these metrics via JMX as well. JMX is still heavily used, and many users have existing infrastructure for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org