You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/28 03:11:25 UTC

[GitHub] [pulsar-client-cpp] tongsucn commented on a diff in pull request #66: Add new interfaces to improve data consuming performance. (#65)

tongsucn commented on code in PR #66:
URL: https://github.com/apache/pulsar-client-cpp/pull/66#discussion_r1007566758


##########
lib/SharedBuffer.h:
##########
@@ -203,6 +203,13 @@ class SharedBuffer {
         writeIdx_ = 0;
     }
 
+    bool pop(std::string& target) {
+        if (data_ == nullptr) return false;

Review Comment:
   Good point. Let me add a flag in `SharedBuffer` to denote if it's a read-only one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org