You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by "slachiewicz (via GitHub)" <gi...@apache.org> on 2026/09/27 15:12:15 UTC
[PR] THRIFT-6385: Skip the RLIMIT_AS test case where the limit is unsupported [thrift]
slachiewicz opened a new pull request, #3969:
URL: https://github.com/apache/thrift/pull/3969
macOS rejects an `RLIMIT_AS` limit with `EINVAL`, so `allocation_failure_on_the_io_thread_does_not_end_the_process` always failed there. The child now exits with 77 in that case, and the test case reports that it has nothing to check; any other `setrlimit` failure still fails it. Linux accepts the limit, so the case runs there as before.
Verified: TNonblockingServerTest passes on macOS 27 (arm64).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-6385: Skip the RLIMIT_AS test case where the limit is unsupported [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3969:
URL: https://github.com/apache/thrift/pull/3969#issuecomment-6252489259
### Code review
No blocking issues found. Checked for bugs and CLAUDE.md compliance.
One suggestion, below the bar for an issue but verified:
- The new comment says macOS does not support an `RLIMIT_AS` limit at all, and the skip message says the same. XNU does implement it: `dosetrlimit()` hands the limit to `vm_map_set_size_limit()`, which fails, and `setrlimit()` returns `EINVAL`, only when the new limit is below the address space the process has already mapped. A macOS process maps far more than 256 MiB. Skipping on `EINVAL` is right; the comment and the message could name that reason instead.
https://github.com/apache/thrift/blob/93f0f36d427cd20df4b9c198a5e1748b76f3133d/lib/cpp/test/TNonblockingServerTest.cpp#L455-L459
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-6385: Skip the RLIMIT_AS test case where the limit is unsupported [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G merged PR #3969:
URL: https://github.com/apache/thrift/pull/3969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org