[GitHub] [zookeeper] eolivelli commented on issue #1083: [ZOOKEEPER-3540] Avoid client port unavailable by skip binding the same client port during reconfig

[GitBox <gi...@apache.org>]

eolivelli commented on issue #1083: [ZOOKEEPER-3540] Avoid client port unavailable by skip binding the same client port during reconfig
URL: https://github.com/apache/zookeeper/pull/1083#issuecomment-529570983
 
 
   @lvfangmin the change looks good to me
   please fix Checkstyle issues, then this patch is okay for me.
   
   ```
   [INFO] There are 10 errors reported by Checkstyle 8.17 with checkstyle-strict.xml ruleset.
   
   [ERROR] src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java:[627,85] (whitespace) OperatorWrap: '&&' should be on a new line.
   
   [ERROR] src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java:[628,67] (whitespace) OperatorWrap: '&&' should be on a new line.
   
   [ERROR] src/test/java/org/apache/zookeeper/server/NettyServerCnxnFactoryTest.java:[21,8] (imports) UnusedImports: Unused import: io.netty.channel.Channel.
   
   [ERROR] src/test/java/org/apache/zookeeper/server/NettyServerCnxnFactoryTest.java:[23] (imports) ImportOrder: Extra separation in import group before 'org.apache.zookeeper.PortAssignment'
   
   [ERROR] src/test/java/org/apache/zookeeper/server/NettyServerCnxnFactoryTest.java:[25] (imports) ImportOrder: Extra separation in import group before 'org.junit.After'
   
   [ERROR] src/test/java/org/apache/zookeeper/server/NettyServerCnxnFactoryTest.java:[25,8] (imports) UnusedImports: Unused import: org.junit.After.
   
   [ERROR] src/test/java/org/apache/zookeeper/server/NettyServerCnxnFactoryTest.java:[27,8] (imports) UnusedImports: Unused import: org.junit.Before.
   
   [ERROR] src/test/java/org/apache/zookeeper/server/NettyServerCnxnFactoryTest.java:[30] (imports) ImportOrder: Extra separation in import group before 'java.io.IOException'
   
   [ERROR] src/test/java/org/apache/zookeeper/server/NettyServerCnxnFactoryTest.java:[30] (imports) ImportOrder: Import java.io.IOException appears after other imports that it should precede
   
   [ERROR] src/test/java/org/apache/zookeeper/server/NettyServerCnxnFactoryTest.java:[30,8] (imports) UnusedImports: Unused import: java.io.IOException.
   ```
   
   Is it a good idea to add it to 3.5 branch ? I feel this is a desirable change.
   I didn't notice  that we always perform re-bind during reconfig even the address is not changed.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services