You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by to...@apache.org on 2016/04/26 08:11:28 UTC
incubator-kudu git commit: lock_manager: remove an outdated TODO
Repository: incubator-kudu
Updated Branches:
refs/heads/master aa9bf3a6a -> 1fa4b10a6
lock_manager: remove an outdated TODO
There was an old TODO about a bug if the same row was updated
twice in the same batch. This was fixed many months back.
Change-Id: I89a945d3686d17c5498cc8e8262f33f70419394a
Reviewed-on: http://gerrit.cloudera.org:8080/2867
Reviewed-by: David Ribeiro Alves <da...@cloudera.com>
Tested-by: Kudu Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/1fa4b10a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/1fa4b10a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/1fa4b10a
Branch: refs/heads/master
Commit: 1fa4b10a67171a783b1555ea0b90165d38d78ed7
Parents: aa9bf3a
Author: Todd Lipcon <to...@apache.org>
Authored: Mon Apr 25 22:19:07 2016 -0700
Committer: Todd Lipcon <to...@apache.org>
Committed: Tue Apr 26 06:10:32 2016 +0000
----------------------------------------------------------------------
src/kudu/tablet/lock_manager.cc | 3 ---
1 file changed, 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/1fa4b10a/src/kudu/tablet/lock_manager.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/lock_manager.cc b/src/kudu/tablet/lock_manager.cc
index d83005f..f38a1dd 100644
--- a/src/kudu/tablet/lock_manager.cc
+++ b/src/kudu/tablet/lock_manager.cc
@@ -341,9 +341,6 @@ LockManager::LockStatus LockManager::Lock(const Slice& key,
// we opt to perform more fine grained locking, possibly letting transactions
// release a portion of the locks they no longer need, this no longer is OK.
if (ANNOTATE_UNPROTECTED_READ((*entry)->holder_) == tx) {
- // TODO: this is likely to be problematic even today: if you issue two
- // UPDATEs for the same row in the same transaction, we can get:
- // "deltamemstore.cc:74] Check failed: !mutation.exists() Already have an entry ..."
(*entry)->recursion_++;
return LOCK_ACQUIRED;
}