You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/06/12 19:29:02 UTC

[GitHub] [iceberg] rdsr commented on a change in pull request #1110: Add a tolerance check of 1 minute to prevent small clock skews to break commits

rdsr commented on a change in pull request #1110:
URL: https://github.com/apache/iceberg/pull/1110#discussion_r439605204



##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -257,14 +260,26 @@ public String toString() {
     }
 
     MetadataLogEntry previous = null;
+    // TODO: this check seems redundant if we are checking lastUpdatedMillis below

Review comment:
       @rdblue . Thoughts on this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org