You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/02/07 21:46:10 UTC
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request
#17546: enabling build stage gpu_int64 to enable large tensor nightly runs
apeforest commented on a change in pull request #17546: enabling build stage gpu_int64 to enable large tensor nightly runs
URL: https://github.com/apache/incubator-mxnet/pull/17546#discussion_r376622564
##########
File path: tests/nightly/JenkinsfileForBinaries
##########
@@ -49,7 +49,7 @@ core_logic: {
utils.pack_lib('cpu_int64', mx_cmake_lib)
}
}
- },
+ }*/,
Review comment:
I think this is a little bit confusing. We are actually testing cpu context on GPU platforms here. The reason we don't use CPU node is simply the CPU node type does not have big enough memory as GPU node.
We should either modify the CPU node type with a memory optimized one such as R5 (this is the ideal solution)
Or we rename the pipeline stage so that it's clear to people these are tests running on CPUs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services