You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/09/14 14:25:02 UTC
[GitHub] [accumulo] milleruntime opened a new pull request #2270: Rename CompactionTask to InternalJob
milleruntime opened a new pull request #2270:
URL: https://github.com/apache/accumulo/pull/2270
* Rename CompactionTask to InternalJob to be consistent with ExternalJob
* Rename some variables to match InternalJob type
* Fix some wording in comments
* Add javadoc to SubmittedJob
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on pull request #2270: Rename CompactionTask to InternalJob
Posted by GitBox <gi...@apache.org>.
keith-turner commented on pull request #2270:
URL: https://github.com/apache/accumulo/pull/2270#issuecomment-919302748
> Perhaps @keith-turner may have had some other ideas?
I think this change is good, it makes the type name more consistent with its sibling and parent types. If there were to be a change it should probably encompass the entire type tree making them all consistent. I am happy w/ `Job`, but there are possibilities like `plan`, `task`, `work`, etc.. The purpose of the parent type is to encapsulate information about compaction work that needs to be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2270: Rename CompactionTask to InternalJob
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2270:
URL: https://github.com/apache/accumulo/pull/2270#issuecomment-919289779
> Without understanding the code - it seems that internalJob and externalJob miss a chance to provide context with what they are doing, esp. if strictly related to compactions.
We could add "compaction" to the names but that seems unnecessary as they are only used within the `CompactionExecutor` and tserver.compaction package. If you follow the code from tserver, it is more clear then taken out of context in a PR. A `CompactionJob` is the immutable object that will get run. A `SubmittedJob` is a wrapper around a `CompactionJob`, that provides the status. Then `ExternalJob` and `InternalJob` are two types of `SubmittedJob` that can be run.
> Also, although task and job are interchangeable, task seems to imply something that is narrow in scope and maybe just a step - job seems to imply larger and self contained. Like you submit a MR job that can contain multiple tasks. So not sure what is more appropriate in this context.
It seems we could settle on Job here as a name for a unit of work. Perhaps @keith-turner may have had some other ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #2270: Rename CompactionTask to InternalJob
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #2270:
URL: https://github.com/apache/accumulo/pull/2270#issuecomment-919314188
OK I will name the variables to be consistent with the `Job` types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime merged pull request #2270: Rename CompactionTask to InternalJob
Posted by GitBox <gi...@apache.org>.
milleruntime merged pull request #2270:
URL: https://github.com/apache/accumulo/pull/2270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org