[jira] [Comment Edited] (PHOENIX-6706) Improve build performance of modules

["Istvan Toth (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537930#comment-17537930 ] 

Istvan Toth edited comment on PHOENIX-6706 at 5/17/22 4:09 AM:
---------------------------------------------------------------

As I noted on the PR, this would build the shaded artifacts with some previously installed phoenix-core version, instead of the one built from the current source, which would be a nightmare.


was (Author: stoty):
As I noted on the PR, this would build the shaded artifacts with some previously installed phoenix-core version, instead of the current source, which would be a nightmare.

> Improve build performance of modules
> ------------------------------------
>
>                 Key: PHOENIX-6706
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6706
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 5.2.0
>            Reporter: Bing-ok
>            Priority: Minor
>         Attachments: image-2022-05-04-10-48-49-550.png, image-2022-05-04-10-48-57-132.png
>
>
> Hi, I'm now using {*}phoenix{*}. I found that the build time of the project is not very fast when I used  *mvn -T 1C install -DskipTests* command to build the project during Github Actions. So I try to speed up the build performance of the project. The goal here is to clean up dependencies between maven modules in the project in order to improve the build performance.
> Thread usage before cleaning up module dependencies was this:
> !image-2022-05-04-10-48-49-550.png!
> Using *mvn dependency:analyze* command I managed to have an overview of the unused dependencies of every module. I focused only on the dependencies between modules. The following dependencies can be cleaned up:
> {noformat}
> org.apache.phoenix:phoenix-client-embedded-hbase-2.4(/phoenix-client-parent/phoenix-client-embedded) -> org.apache.phoenix:phoenix-core(phoenix-core)
> org.apache.phoenix:phoenix-client-embedded-hbase-2.4(phoenix-client-parent/phoenix-client-embedded) -> org.apache.phoenix:phoenix-hbase-compat-2.4.1(phoenix-hbase-compat-2.4.1){noformat}
> After clean up, the build time has been reduced by *3min* when I use parallel build during Github Actions.
> Thread usage after cleaning up module dependencies was this:
> !image-2022-05-04-10-48-57-132.png!
> Could you help me review this issue? I can submit a PR to improve build performance of the project.
> Thank you very much for your attention.
> Best regards.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)