You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by foxish <gi...@git.apache.org> on 2018/04/03 18:47:20 UTC

[GitHub] spark pull request #20811: [SPARK-23668][K8S] Add config option for passing ...

Github user foxish commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20811#discussion_r178924651
  
    --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala ---
    @@ -54,6 +54,12 @@ private[spark] object Config extends Logging {
           .checkValues(Set("Always", "Never", "IfNotPresent"))
           .createWithDefault("IfNotPresent")
     
    +  val IMAGE_PULL_SECRET =
    +    ConfigBuilder("spark.kubernetes.imagePullSecret")
    --- End diff --
    
    Given there's an option `spark.kubernetes.container.image.pullPolicy`, we should make this consistent as `spark.kubernetes.container.image.pullSecret`
    
    
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org