You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by acton393 <gi...@git.apache.org> on 2017/05/02 08:40:41 UTC

[GitHub] incubator-weex pull request #305: *[ios] fix text height when drawing text

GitHub user acton393 opened a pull request:

    https://github.com/apache/incubator-weex/pull/305

    *[ios] fix text height when drawing text

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/acton393/incubator-weex iOS-0.12-dev-text-refactor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/305.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #305
    
----
commit 83c8208c8f6e59ce95a9f540be93d42bc61db48a
Author: acton393 <zh...@gmail.com>
Date:   2017-05-02T08:33:34Z

    * [ios] fix text height below iOS 10

commit 601b6e428c49c9e7bdcba9e0746409600287111a
Author: acton393 <zh...@gmail.com>
Date:   2017-05-02T08:36:57Z

    * [ios] add comment for modifications

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #305: *[ios] fix text height when drawing text

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/305
  
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true" data-kind="Message">
              1 Message
          </th>
         </tr>
      </thead>
      <tbody>
        <tr>
          <td>:book:</td>
          <td data-sticky="false">Executed 53 tests, with 0 failures (0 unexpected) in 59.493 (59.542) seconds</td>
        </tr>
      </tbody>
    </table>
    
    <p align="right" data-meta="generated_by_danger">
      Generated by :no_entry_sign: <a href="http://danger.systems/">danger</a>
    </p>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #305: *[ios] fix text height when drawing text

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/305


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---