You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ueshin (via GitHub)" <gi...@apache.org> on 2025/11/25 23:41:11 UTC
[PR] [SPARK-54517][PYTHON][TESTS] Forward-port test util decorators [spark]
ueshin opened a new pull request, #53223:
URL: https://github.com/apache/spark/pull/53223
### What changes were proposed in this pull request?
Forward-port test util decorators for skipping tests in Spark Connect cross version tests.
- `skip_if_server_version_is`
- `skip_if_server_version_is_greater_than_or_equal_to`
### Why are the changes needed?
This is a forward-port from #53222.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
N/A
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54517][PYTHON][TESTS] Added utility decorators for Spark Connect parity tests [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #53223: [SPARK-54517][PYTHON][TESTS] Added utility decorators for Spark Connect parity tests
URL: https://github.com/apache/spark/pull/53223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54517][PYTHON][TESTS] Added utility decorators for Spark Connect parity tests [spark]
Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin commented on PR #53223:
URL: https://github.com/apache/spark/pull/53223#issuecomment-3582770710
@dongjoon-hyun oh, sure, let me check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54517][PYTHON][TESTS] Added utility decorators for Spark Connect parity tests [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #53223:
URL: https://github.com/apache/spark/pull/53223#issuecomment-3582772975
Thank you so much~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54517][PYTHON][TESTS] Added utility decorators for Spark Connect parity tests [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #53223:
URL: https://github.com/apache/spark/pull/53223#issuecomment-3582734086
Hi, @ueshin . It seems a little weird but this PR causes some CI failures. Could you take a look at that?
https://github.com/apache/spark/actions/runs/19708303738/job/56461909042
```
File "/__w/spark/spark/python/pyspark/testing/connectutils.py", line 312, in <module>
) -> Callable[[...], ...]:
^^^^^^^^^^^^^^^^^^^^
File "/usr/local/pypy/pypy3.10/lib/pypy3.10/typing.py", line 1206, in __getitem__
return self.__getitem_inner__(params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/pypy/pypy3.10/lib/pypy3.10/typing.py", line 312, in inner
return func(*args, **kwds)
^^^^^^^^^^^^^^^^^^^
File "/usr/local/pypy/pypy3.10/lib/pypy3.10/typing.py", line 1212, in __getitem_inner__
result = _type_check(result, msg)
^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/pypy/pypy3.10/lib/pypy3.10/typing.py", line 176, in _type_check
raise TypeError(f"{msg} Got {arg!r:.100}.")
TypeError: Callable[args, result]: result must be a type. Got Ellipsis.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54517][PYTHON][TESTS] Added utility decorators for Spark Connect parity tests [spark]
Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin commented on PR #53223:
URL: https://github.com/apache/spark/pull/53223#issuecomment-3582819807
Submitted the follow-up: https://github.com/apache/spark/pull/53238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org