You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/09/27 04:49:19 UTC

[GitHub] [iceberg] stevenzwu commented on pull request #3130: Flink: support write watermark in snapshot

stevenzwu commented on pull request #3130:
URL: https://github.com/apache/iceberg/pull/3130#issuecomment-927527676


   @liubo1022126 I would add option 3: set the watermark as table property (not snapshot summary). This is what we did at Netflix before. 
   * pro: Storing watermark in table properties make it easier for consumer
   * con: It needs `Table#newTransaction` to commit append and table properties update together. Transaction change might require bigger refactor in the IcebergFilesCommitter. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org