[GitHub] [spark] sunchao commented on a change in pull request #33526: [SPARK-34952][SQL][FOLLOW-UP] DSv2 aggregate push down follow-up

[GitBox <gi...@apache.org>]

sunchao commented on a change in pull request #33526:
URL: https://github.com/apache/spark/pull/33526#discussion_r677824345



##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/SupportsPushDownAggregates.java
##########
@@ -51,6 +49,8 @@
    * Pushes down Aggregation to datasource. The order of the datasource scan output columns should
    * be: grouping columns, aggregate columns (in the same order as the aggregate functions in
    * the given Aggregation).
+   *
+   * Returns true if the aggregation can be pushed down to datasource.

Review comment:
       nit: maybe "@return true if the aggregation can be pushed down to datasource. False otherwise."




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org