You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/06/15 17:32:07 UTC
[kudu-CR] alter table-test and delete table-itest may conflict on master ports
Hello David Ribeiro Alves, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7189
to review the following change.
Change subject: alter_table-test and delete_table-itest may conflict on master ports
......................................................................
alter_table-test and delete_table-itest may conflict on master ports
Change-Id: I22d39c543e2a04c328e986efabf9e59fa328bfc9
---
M src/kudu/integration-tests/CMakeLists.txt
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/7189/1
--
To view, visit http://gerrit.cloudera.org:8080/7189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I22d39c543e2a04c328e986efabf9e59fa328bfc9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
[kudu-CR] alter table-test and delete table-itest may conflict on master ports
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: alter_table-test and delete_table-itest may conflict on master ports
......................................................................
Patch Set 1:
Another solution here would be for MiniCluster to use the special local loopback IPs (see https://issues.apache.org/jira/browse/KUDU-1123)
--
To view, visit http://gerrit.cloudera.org:8080/7189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I22d39c543e2a04c328e986efabf9e59fa328bfc9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] alter table-test and delete table-itest may conflict on master ports
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: alter_table-test and delete_table-itest may conflict on master ports
......................................................................
Patch Set 1:
> Ideally all of our tests would switch to the new ports
> post-Restart(); do some not do that?
If you only bounce the master but not the tablet servers then we currently don't have a way to support that as far as I know.
--
To view, visit http://gerrit.cloudera.org:8080/7189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I22d39c543e2a04c328e986efabf9e59fa328bfc9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] alter table-test and delete table-itest may conflict on master ports
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: alter_table-test and delete_table-itest may conflict on master ports
......................................................................
Patch Set 1:
> Hmm, maybe the problem is just delete_table-itest then. It shuts
> down and restarts its master so maybe that it why it is conflicting
> with other stuff. Perhaps I should just set it to RUN_SERIAL?
Oh, so that's what you're trying to fix? Hmm. Any idea why we don't allow Restart() to bind to a new ephemeral port? Are there tests that would fail if a server's ports changed across a Restart()? Ideally all of our tests would switch to the new ports post-Restart(); do some not do that?
--
To view, visit http://gerrit.cloudera.org:8080/7189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I22d39c543e2a04c328e986efabf9e59fa328bfc9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] alter table-test and delete table-itest may conflict on master ports
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change.
Change subject: alter_table-test and delete_table-itest may conflict on master ports
......................................................................
Abandoned
Superseded by https://gerrit.cloudera.org/7274
--
To view, visit http://gerrit.cloudera.org:8080/7189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I22d39c543e2a04c328e986efabf9e59fa328bfc9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] alter table-test and delete table-itest may conflict on master ports
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: alter_table-test and delete_table-itest may conflict on master ports
......................................................................
Patch Set 1:
Where's the conflict? None of the tests in these suites use multiple masters, so AFAICT they always use ephemeral ports when starting their master.
--
To view, visit http://gerrit.cloudera.org:8080/7189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I22d39c543e2a04c328e986efabf9e59fa328bfc9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] alter table-test and delete table-itest may conflict on master ports
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: alter_table-test and delete_table-itest may conflict on master ports
......................................................................
Patch Set 1:
Hmm, maybe the problem is just delete_table-itest then. It shuts down and restarts its master so maybe that it why it is conflicting with other stuff. Perhaps I should just set it to RUN_SERIAL?
--
To view, visit http://gerrit.cloudera.org:8080/7189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I22d39c543e2a04c328e986efabf9e59fa328bfc9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No