You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/01 10:29:31 UTC

[GitHub] [incubator-nuttx] anchao opened a new pull request #1345: make/export: 

anchao opened a new pull request #1345:
URL: https://github.com/apache/incubator-nuttx/pull/1345


   ## Summary
   
   1. make/POSTBUILD: make BIN directory configurable
   enhance the post build can support configurable BIN directory
   
   2. make/export: export post build script
   post build processing is also necessary for import compile
   
   3. make/export: use LDNAME instead of LDSCRIPT
   use LDNAME instead of LDSCRIPT to avoid invalid native path exported to the import build
   
   ## Impact
   make export
   
   ## Testing
   
   ```
   $ cd $(NUTTX_DIR)
   $ ./tools/configure.sh stm32f429i-disco:nsh
   $ make export -j12
   
   $ cd $(APPS_DIR)
   $ ./tools/mkimport.sh -x $(NUTTX_DIR)/nuttx-export-9.1.0.zip
   $ make import -j12
   ...
   LD: nuttx
   make[1]: Leaving directory '/home/archer/code/apps/import'
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #1345: make/export: enhance make export

Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #1345:
URL: https://github.com/apache/incubator-nuttx/pull/1345#discussion_r448308618



##########
File path: tools/Makefile.unix
##########
@@ -421,7 +421,7 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y)
 		cp -f uImage /tftpboot/uImage; \
 	fi
 endif
-	$(call POSTBUILD)
+	$(call POSTBUILD, $(TOPDIR))

Review comment:
       > Similar change needs to be done to the Makefile.win.
   Got.
   
   > Out of curiosity, are you using TOPDIR in your POSTBUILD script to move around the final BIN?
   Yes, just to improve compatibility, postbuild will require different BIN directories in some scenarios on out platform.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #1345: make/export: enhance make export

Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #1345:
URL: https://github.com/apache/incubator-nuttx/pull/1345#discussion_r448308618



##########
File path: tools/Makefile.unix
##########
@@ -421,7 +421,7 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y)
 		cp -f uImage /tftpboot/uImage; \
 	fi
 endif
-	$(call POSTBUILD)
+	$(call POSTBUILD, $(TOPDIR))

Review comment:
       > Similar change needs to be done to the Makefile.win.
   
   
   Got.
   
   > Out of curiosity, are you using TOPDIR in your POSTBUILD script to move around the final BIN?
   
   
   Yes, just to improve compatibility, postbuild will require different BIN directories in some scenarios on out platform.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 merged pull request #1345: make/export: enhance make export

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #1345:
URL: https://github.com/apache/incubator-nuttx/pull/1345


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1345: make/export: enhance make export

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #1345:
URL: https://github.com/apache/incubator-nuttx/pull/1345#discussion_r448274174



##########
File path: tools/Makefile.unix
##########
@@ -421,7 +421,7 @@ ifeq ($(CONFIG_UBOOT_UIMAGE),y)
 		cp -f uImage /tftpboot/uImage; \
 	fi
 endif
-	$(call POSTBUILD)
+	$(call POSTBUILD, $(TOPDIR))

Review comment:
       Similar change needs to be done to the Makefile.win.
   
   Out of curiosity, are you using TOPDIR in your POSTBUILD script to move around the final BIN?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org