You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by Henryk Konsek <he...@gmail.com> on 2014/01/08 22:01:54 UTC
Spring 4 update
Hi,
Do we have any particular plans to upgrade Spring to version 4? I
guess this might be pretty invasive change, so it might be worth to
discuss it here :) .
BTW I can create Jira ticket and handle the update process.
Cheers.
PS I've become interested in the topic, because Hibernate 4.3 requires
Spring 4, so pretty soon user will start to ask us when we plan to
upgrade Spring version.
--
Henryk Konsek
http://henryk-konsek.blogspot.com
Re: Spring 4 update
Posted by David Karlsen <da...@gmail.com>.
There is a jira already: https://issues.apache.org/jira/browse/CAMEL-7074
2014/1/8 Christoph Emmersberger <ce...@gmail.com>
> Hi Henryk
>
> please go ahead and create the JIRA.
>
> However, as far as I know there will be a dependency to the version that
> Karaf provides.
>
> Many greets and kind regards,
>
> Christoph
>
> On 08 Jan 2014, at 22:01, Henryk Konsek <he...@gmail.com> wrote:
>
> > Hi,
> >
> > Do we have any particular plans to upgrade Spring to version 4? I
> > guess this might be pretty invasive change, so it might be worth to
> > discuss it here :) .
> >
> > BTW I can create Jira ticket and handle the update process.
> >
> > Cheers.
> >
> > PS I've become interested in the topic, because Hibernate 4.3 requires
> > Spring 4, so pretty soon user will start to ask us when we plan to
> > upgrade Spring version.
> >
> > --
> > Henryk Konsek
> > http://henryk-konsek.blogspot.com
>
>
--
--
David J. M. Karlsen - http://www.linkedin.com/in/davidkarlsen
Re: Spring 4 update
Posted by Christoph Emmersberger <ce...@gmail.com>.
Hi Henryk
please go ahead and create the JIRA.
However, as far as I know there will be a dependency to the version that Karaf provides.
Many greets and kind regards,
Christoph
On 08 Jan 2014, at 22:01, Henryk Konsek <he...@gmail.com> wrote:
> Hi,
>
> Do we have any particular plans to upgrade Spring to version 4? I
> guess this might be pretty invasive change, so it might be worth to
> discuss it here :) .
>
> BTW I can create Jira ticket and handle the update process.
>
> Cheers.
>
> PS I've become interested in the topic, because Hibernate 4.3 requires
> Spring 4, so pretty soon user will start to ask us when we plan to
> upgrade Spring version.
>
> --
> Henryk Konsek
> http://henryk-konsek.blogspot.com
Re: Spring 4 update
Posted by Henryk Konsek <he...@gmail.com>.
> FYI I started to remove JpaTemplate dependencies from BAM component.
Done. I'll check out what else (except of CXF) is not building
properly with Spring 4.
Cheers.
--
Henryk Konsek
http://henryk-konsek.blogspot.com
Re: Spring 4 update
Posted by Henryk Konsek <he...@gmail.com>.
> [2] https://issues.apache.org/jira/browse/CAMEL-7126
FYI I started to remove JpaTemplate dependencies from BAM component.
Cheers.
--
Henryk Konsek
http://henryk-konsek.blogspot.com
Re: Spring 4 update
Posted by Henryk Konsek <he...@gmail.com>.
> TestNG tests now passed with both Spring 3 and Spring 4. Fixed in
> CAMEL-7124 [1].
I created dedicated Jira subtasks for CXF [1] and BAM [2] components
whose fail to build with Spring 4. I'll fix BAM component to work with
Spring 4 in coming days.
Cheers.
[1] https://issues.apache.org/jira/browse/CAMEL-7127
[2] https://issues.apache.org/jira/browse/CAMEL-7126
--
Henryk Konsek
http://henryk-konsek.blogspot.com
Re: Spring 4 update
Posted by Henryk Konsek <he...@gmail.com>.
> In the meantime I'll nail the TestNG test error that occurs with
> Spring 4. This should be low hanging fruit comparing to CXF :) .
TestNG tests now passed with both Spring 3 and Spring 4. Fixed in
CAMEL-7124 [1].
I'll take a look at the other Spring 4 issues starting from tomorrow.
[1] https://issues.apache.org/jira/browse/CAMEL-7124
--
Henryk Konsek
http://henryk-konsek.blogspot.com
Re: Spring 4 update
Posted by Henryk Konsek <he...@gmail.com>.
> It’s test, we could add a profile to test different version password callback with different CXF version.
In the meantime I'll nail the TestNG test error that occurs with
Spring 4. This should be low hanging fruit comparing to CXF :) .
Cheers.
--
Henryk Konsek
http://henryk-konsek.blogspot.com
Re: Spring 4 update
Posted by Willem Jiang <wi...@gmail.com>.
On January 9, 2014 at 10:30:41 PM, Daniel Kulp (dkulp@apache.org) wrote:
>
>
> On Jan 9, 2014, at 8:51 AM, Willem Jiang
> wrote:
>
> > CXF3.0 mile stone 2[1] will be released this month.
> >
> > [1]http://cxf.547215.n5.nabble.com/When-Will-3-0-0-Release-td5738348.html
>
> Right, but flipping Camel over to grabbing it instead of 2.7.x
> will also require a little work. I’ve setup both camel-cxf-transport
> and camel-cxf to work with either 2.7.x or 3.0.x, but the itests
> have some problems due to the password callback classes changing.
> Thus, they are more difficult to get working with both 2.7 and
> 3.0.
It’s test, we could add a profile to test different version password callback with different CXF version.
>
> Dan
>
>
>
> >
> > --
> > Willem Jiang
> >
> > Red Hat, Inc.
> > Web: http://www.redhat.com
> > Blog: http://willemjiang.blogspot.com(http://willemjiang.blogspot.com/)
> (English)
> > http://jnn.iteye.com(http://jnn.javaeye.com/) (Chinese)
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> >
> >
> > On January 9, 2014 at 5:36:40 PM, Henryk Konsek (hekonsek@gmail.com)
> wrote:
> >>
> >>> In CXF 3.0 the dependency of SingleConnectionFactory102
> is
> >> removed,
> >>> so this issue could be resolve when we upgrade the CXF version
> >> to next
> >>> milestone release of CXF 3.0.
> >>
> >> Thank you Willem. Any predictions when 3.0 milestone could
> happen?
> >> :)
> >>
> >> --
> >> Henryk Konsek
> >> http://henryk-konsek.blogspot.com
> >>
> >
>
> --
> Daniel Kulp
> dkulp@apache.org - http://dankulp.com/blog
> Talend Community Coder - http://coders.talend.com
>
>
Re: Spring 4 update
Posted by Daniel Kulp <dk...@apache.org>.
On Jan 9, 2014, at 8:51 AM, Willem Jiang <wi...@gmail.com> wrote:
> CXF3.0 mile stone 2[1] will be released this month.
>
> [1]http://cxf.547215.n5.nabble.com/When-Will-3-0-0-Release-td5738348.html
Right, but flipping Camel over to grabbing it instead of 2.7.x will also require a little work. I’ve setup both camel-cxf-transport and camel-cxf to work with either 2.7.x or 3.0.x, but the itests have some problems due to the password callback classes changing. Thus, they are more difficult to get working with both 2.7 and 3.0.
Dan
>
> --
> Willem Jiang
>
> Red Hat, Inc.
> Web: http://www.redhat.com
> Blog: http://willemjiang.blogspot.com(http://willemjiang.blogspot.com/) (English)
> http://jnn.iteye.com(http://jnn.javaeye.com/) (Chinese)
> Twitter: willemjiang
> Weibo: 姜宁willem
>
>
>
> On January 9, 2014 at 5:36:40 PM, Henryk Konsek (hekonsek@gmail.com) wrote:
>>
>>> In CXF 3.0 the dependency of SingleConnectionFactory102 is
>> removed,
>>> so this issue could be resolve when we upgrade the CXF version
>> to next
>>> milestone release of CXF 3.0.
>>
>> Thank you Willem. Any predictions when 3.0 milestone could happen?
>> :)
>>
>> --
>> Henryk Konsek
>> http://henryk-konsek.blogspot.com
>>
>
--
Daniel Kulp
dkulp@apache.org - http://dankulp.com/blog
Talend Community Coder - http://coders.talend.com
Re: Spring 4 update
Posted by Willem Jiang <wi...@gmail.com>.
CXF3.0 mile stone 2[1] will be released this month.
[1]http://cxf.547215.n5.nabble.com/When-Will-3-0-0-Release-td5738348.html
--
Willem Jiang
Red Hat, Inc.
Web: http://www.redhat.com
Blog: http://willemjiang.blogspot.com(http://willemjiang.blogspot.com/) (English)
http://jnn.iteye.com(http://jnn.javaeye.com/) (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem
On January 9, 2014 at 5:36:40 PM, Henryk Konsek (hekonsek@gmail.com) wrote:
>
> > In CXF 3.0 the dependency of SingleConnectionFactory102 is
> removed,
> > so this issue could be resolve when we upgrade the CXF version
> to next
> > milestone release of CXF 3.0.
>
> Thank you Willem. Any predictions when 3.0 milestone could happen?
> :)
>
> --
> Henryk Konsek
> http://henryk-konsek.blogspot.com
>
Re: Spring 4 update
Posted by Henryk Konsek <he...@gmail.com>.
> In CXF 3.0 the dependency of SingleConnectionFactory102 is removed,
> so this issue could be resolve when we upgrade the CXF version to next
> milestone release of CXF 3.0.
Thank you Willem. Any predictions when 3.0 milestone could happen? :)
--
Henryk Konsek
http://henryk-konsek.blogspot.com
Re: Spring 4 update
Posted by Willem Jiang <wi...@gmail.com>.
Hi Henryk,
In CXF 3.0 the dependency of SingleConnectionFactory102 is removed, so this issue could be resolve when we upgrade the CXF version to next milestone release of CXF 3.0.
--
Willem Jiang
Red Hat, Inc.
Web: http://www.redhat.com
Blog: http://willemjiang.blogspot.com(http://willemjiang.blogspot.com/) (English)
http://jnn.iteye.com(http://jnn.javaeye.com/) (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem
On January 9, 2014 at 4:36:33 PM, Henryk Konsek (hekonsek@gmail.com) wrote:
>
> > Thanks Christian. Let's figure out then if the build passes.
> I created
> > Jira ticket for this task [2].
>
> According to the Jenkins (1) we got three tests issues related
> to
> Spring API upgrade:
>
> org.apache.camel.component.cxf.jms.CxfEndpointJMSConsumerTest.testInvocation
> org.apache.camel.example.cxf.httptojms.CxfHttpJmsClientServerTest.testClientInvocation
> org.apache.camel.testng.patterns.DebugSpringTest.setUp
>
> The CXF errors are cause by CXF using deprecated Spring 3 API for
> JMS.
> Maybe someone from CXF community could tell us more about perspectives
> for switching from deprecated
> org.springframework.jms.connection.SingleConnectionFactory102
> to
> recommended org.springframework.jms.connection.SingleConnectionFactory?
>
> (1) https://builds.apache.org/view/A-D/view/Camel/job/Camel.trunk.fulltest.spring4/1/
>
> --
> Henryk Konsek
> http://henryk-konsek.blogspot.com
>
Re: Spring 4 update
Posted by Henryk Konsek <he...@gmail.com>.
> Thanks Christian. Let's figure out then if the build passes. I created
> Jira ticket for this task [2].
According to the Jenkins (1) we got three tests issues related to
Spring API upgrade:
org.apache.camel.component.cxf.jms.CxfEndpointJMSConsumerTest.testInvocation
org.apache.camel.example.cxf.httptojms.CxfHttpJmsClientServerTest.testClientInvocation
org.apache.camel.testng.patterns.DebugSpringTest.setUp
The CXF errors are cause by CXF using deprecated Spring 3 API for JMS.
Maybe someone from CXF community could tell us more about perspectives
for switching from deprecated
org.springframework.jms.connection.SingleConnectionFactory102 to
recommended org.springframework.jms.connection.SingleConnectionFactory?
(1) https://builds.apache.org/view/A-D/view/Camel/job/Camel.trunk.fulltest.spring4/1/
--
Henryk Konsek
http://henryk-konsek.blogspot.com
Re: Spring 4 update
Posted by Henryk Konsek <he...@gmail.com>.
Yeah, we might reuse CAMEL-7074 [1].
> We already have a Spring 4 profile [1] (line 2752).
Thanks Christian. Let's figure out then if the build passes. I created
Jira ticket for this task [2].
Are there any others things we should consider in the context of
Spring 4 upgrade? Jakub Korab mentioned on twitter that Spring DM
distributed with the current version of ServiceMix doesn't work with
Spring 4. We should investigate this as well. Here is another ticket
[3] for this task.
If you can think of anything else that we should cover to successfully
upgraded Spring to version 4, I propose to add it as a subtask to
CAMEL-7074.
Cheers.
[1] https://issues.apache.org/jira/browse/CAMEL-7074
[2] https://issues.apache.org/jira/browse/CAMEL-7114
[3] https://issues.apache.org/jira/browse/CAMEL-7115
--
Henryk Konsek
http://henryk-konsek.blogspot.com
Re: Spring 4 update
Posted by Christoph Emmersberger <ce...@gmail.com>.
One of the cool features of spring 4 is the implementation of the BOM concept.
This might reduce the POM for quite a few version numbers.
[1] http://docs.spring.io/spring/docs/4.0.0.RELEASE/spring-framework-reference/htmlsingle/#overview-maven-bom
On 08 Jan 2014, at 23:05, Christian Müller <ch...@gmail.com> wrote:
> We already have a Spring 4 profile [1] (line 2752).
> cmueller$ mvn clean install -Pfastinstall,spring4
>
> I added a Spring 4 Jenkins build today [2]. Let's see how it works.
>
> [1]
> https://git-wip-us.apache.org/repos/asf?p=camel.git;a=blob;f=parent/pom.xml;h=77c7dd5515738c047bedb318e74ab2c3aac8718c;hb=HEAD
> [2]
> https://builds.apache.org/view/A-D/view/Camel/job/Camel.trunk.fulltest.spring4/
>
> Best,
>
> Christian
> -----------------
>
> Software Integration Specialist
>
> Apache Member
> V.P. Apache Camel | Apache Camel PMC Member | Apache Camel committer
> Apache Incubator PMC Member
>
> https://www.linkedin.com/pub/christian-mueller/11/551/642
>
>
> On Wed, Jan 8, 2014 at 10:01 PM, Henryk Konsek <he...@gmail.com> wrote:
>
>> Hi,
>>
>> Do we have any particular plans to upgrade Spring to version 4? I
>> guess this might be pretty invasive change, so it might be worth to
>> discuss it here :) .
>>
>> BTW I can create Jira ticket and handle the update process.
>>
>> Cheers.
>>
>> PS I've become interested in the topic, because Hibernate 4.3 requires
>> Spring 4, so pretty soon user will start to ask us when we plan to
>> upgrade Spring version.
>>
>> --
>> Henryk Konsek
>> http://henryk-konsek.blogspot.com
>>
Re: Spring 4 update
Posted by Christian Müller <ch...@gmail.com>.
We already have a Spring 4 profile [1] (line 2752).
cmueller$ mvn clean install -Pfastinstall,spring4
I added a Spring 4 Jenkins build today [2]. Let's see how it works.
[1]
https://git-wip-us.apache.org/repos/asf?p=camel.git;a=blob;f=parent/pom.xml;h=77c7dd5515738c047bedb318e74ab2c3aac8718c;hb=HEAD
[2]
https://builds.apache.org/view/A-D/view/Camel/job/Camel.trunk.fulltest.spring4/
Best,
Christian
-----------------
Software Integration Specialist
Apache Member
V.P. Apache Camel | Apache Camel PMC Member | Apache Camel committer
Apache Incubator PMC Member
https://www.linkedin.com/pub/christian-mueller/11/551/642
On Wed, Jan 8, 2014 at 10:01 PM, Henryk Konsek <he...@gmail.com> wrote:
> Hi,
>
> Do we have any particular plans to upgrade Spring to version 4? I
> guess this might be pretty invasive change, so it might be worth to
> discuss it here :) .
>
> BTW I can create Jira ticket and handle the update process.
>
> Cheers.
>
> PS I've become interested in the topic, because Hibernate 4.3 requires
> Spring 4, so pretty soon user will start to ask us when we plan to
> upgrade Spring version.
>
> --
> Henryk Konsek
> http://henryk-konsek.blogspot.com
>