[GitHub] [incubator-hop] sramazzina commented on a change in pull request #916: HOP-3020

[GitBox <gi...@apache.org>]

sramazzina commented on a change in pull request #916:
URL: https://github.com/apache/incubator-hop/pull/916#discussion_r664011168



##########
File path: plugins/transforms/splitfieldtorows/src/main/java/org/apache/hop/pipeline/transforms/splitfieldtorows/SplitFieldToRowsMeta.java
##########
@@ -54,31 +55,41 @@
   private static final Class<?> PKG = SplitFieldToRowsMeta.class; // For Translator
 
   /** Field to split */
+  @HopMetadataProperty(key="splitfield", injectionKey = "FIELD_TO_SPLIT", injectionKeyDescription = "SplitFieldsToRow.Injection.FieldToSplit.Description")
   private String splitField;
 
   /** Split field based upon this delimiter. */
+  @HopMetadataProperty(injectionKey = "DELIMITER", injectionKeyDescription = "SplitFieldsToRow.Injection.Delimiter.Description")

Review comment:
       I've not set the key attribute because element's name in xml is same as attribute name so it isn't needed (in my opinion). During the tests  Iimmediately read existing pipeline that is present in integration tests (it was already there) so the compatibility was checked and worked! 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org