You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Bikas Saha (Created) (JIRA)" <ji...@apache.org> on 2012/02/08 09:42:57 UTC
[jira] [Created] (HDFS-2915) HA:
TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
HA: TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
----------------------------------------------------------------------
Key: HDFS-2915
URL: https://issues.apache.org/jira/browse/HDFS-2915
Project: Hadoop HDFS
Issue Type: Sub-task
Components: name-node
Affects Versions: HA branch (HDFS-1623)
Reporter: Bikas Saha
Assignee: Bikas Saha
Priority: Minor
The test deletes the shared edits dir to simulate a failure. Then it calls rollEditLogs() to trigger the deleted dir to be used and fail with an IOException. Unfortunately, deleting the shared dir can put the NN in safe mode due to lack of space. This causes a SafeModeException to be thrown when rollEditDirs() is called. This exception is caught as an IOException in the test but the associated assert in the catch block fails.
This always happens in the debugger because the delay in stepping through causes the safe mode change to happen before rollEditLogs() gets called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2915) HA:
TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
Posted by "Jitendra Nath Pandey (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204861#comment-13204861 ]
Jitendra Nath Pandey commented on HDFS-2915:
--------------------------------------------
+1
> HA: TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
> ----------------------------------------------------------------------
>
> Key: HDFS-2915
> URL: https://issues.apache.org/jira/browse/HDFS-2915
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Priority: Minor
> Attachments: HDFS-2915.HDFS-1623.patch, HDFS-2915.HDFS-1623.patch
>
>
> The test deletes the shared edits dir to simulate a failure. Then it calls rollEditLogs() to trigger the deleted dir to be used and fail with an IOException. Unfortunately, deleting the shared dir can put the NN in safe mode due to lack of space. This causes a SafeModeException to be thrown when rollEditDirs() is called. This exception is caught as an IOException in the test but the associated assert in the catch block fails.
> This always happens in the debugger because the delay in stepping through causes the safe mode change to happen before rollEditLogs() gets called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2915) HA:
TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204889#comment-13204889 ]
Aaron T. Myers commented on HDFS-2915:
--------------------------------------
Rather than log a warning in the event of failure to chmod the dir, why not just assert the result of FileUtil.chmod equals 0? There doesn't seem to e any point in continuing with the test if we somehow failed to set up the environment correctly.
Also, there doesn't seem to be any need to check "if (chmodSucceeded == 0)" before adding back "+w". Just do that always, and then there's no need for the chmodSucceeded variable at all.
> HA: TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
> ----------------------------------------------------------------------
>
> Key: HDFS-2915
> URL: https://issues.apache.org/jira/browse/HDFS-2915
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Priority: Minor
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2915.HDFS-1623.patch, HDFS-2915.HDFS-1623.patch
>
>
> The test deletes the shared edits dir to simulate a failure. Then it calls rollEditLogs() to trigger the deleted dir to be used and fail with an IOException. Unfortunately, deleting the shared dir can put the NN in safe mode due to lack of space. This causes a SafeModeException to be thrown when rollEditDirs() is called. This exception is caught as an IOException in the test but the associated assert in the catch block fails.
> This always happens in the debugger because the delay in stepping through causes the safe mode change to happen before rollEditLogs() gets called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2915) HA:
TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
Posted by "Jitendra Nath Pandey (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204817#comment-13204817 ]
Jitendra Nath Pandey commented on HDFS-2915:
--------------------------------------------
Please remove the commented out code lines.
> HA: TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
> ----------------------------------------------------------------------
>
> Key: HDFS-2915
> URL: https://issues.apache.org/jira/browse/HDFS-2915
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Priority: Minor
> Attachments: HDFS-2915.HDFS-1623.patch
>
>
> The test deletes the shared edits dir to simulate a failure. Then it calls rollEditLogs() to trigger the deleted dir to be used and fail with an IOException. Unfortunately, deleting the shared dir can put the NN in safe mode due to lack of space. This causes a SafeModeException to be thrown when rollEditDirs() is called. This exception is caught as an IOException in the test but the associated assert in the catch block fails.
> This always happens in the debugger because the delay in stepping through causes the safe mode change to happen before rollEditLogs() gets called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2915) HA:
TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203875#comment-13203875 ]
Aaron T. Myers commented on HDFS-2915:
--------------------------------------
bq. I am planning to make the shared dir inaccessible by changing write permissions (instead of deleting the directory). That gets rid all potential race conditions.
Sure, that'd be fine too.
> HA: TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
> ----------------------------------------------------------------------
>
> Key: HDFS-2915
> URL: https://issues.apache.org/jira/browse/HDFS-2915
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Priority: Minor
>
> The test deletes the shared edits dir to simulate a failure. Then it calls rollEditLogs() to trigger the deleted dir to be used and fail with an IOException. Unfortunately, deleting the shared dir can put the NN in safe mode due to lack of space. This causes a SafeModeException to be thrown when rollEditDirs() is called. This exception is caught as an IOException in the test but the associated assert in the catch block fails.
> This always happens in the debugger because the delay in stepping through causes the safe mode change to happen before rollEditLogs() gets called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2915) HA:
TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205419#comment-13205419 ]
Hudson commented on HDFS-2915:
------------------------------
Integrated in Hadoop-Hdfs-HAbranch-build #74 (See [https://builds.apache.org/job/Hadoop-Hdfs-HAbranch-build/74/])
HDFS-2915. HA: TestFailureOfSharedDir.testFailureOfSharedDir() has race condition. Contributed by Bikas Saha.
jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1242522
Files :
* /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-1623.txt
* /hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestFailureOfSharedDir.java
> HA: TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
> ----------------------------------------------------------------------
>
> Key: HDFS-2915
> URL: https://issues.apache.org/jira/browse/HDFS-2915
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Priority: Minor
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2915.HDFS-1623.patch, HDFS-2915.HDFS-1623.patch
>
>
> The test deletes the shared edits dir to simulate a failure. Then it calls rollEditLogs() to trigger the deleted dir to be used and fail with an IOException. Unfortunately, deleting the shared dir can put the NN in safe mode due to lack of space. This causes a SafeModeException to be thrown when rollEditDirs() is called. This exception is caught as an IOException in the test but the associated assert in the catch block fails.
> This always happens in the debugger because the delay in stepping through causes the safe mode change to happen before rollEditLogs() gets called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2915) HA:
TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
Posted by "Bikas Saha (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bikas Saha updated HDFS-2915:
-----------------------------
Attachment: HDFS-2915.HDFS-1623.patch
Sorry. I attached the patch made for testing.
> HA: TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
> ----------------------------------------------------------------------
>
> Key: HDFS-2915
> URL: https://issues.apache.org/jira/browse/HDFS-2915
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Priority: Minor
> Attachments: HDFS-2915.HDFS-1623.patch, HDFS-2915.HDFS-1623.patch
>
>
> The test deletes the shared edits dir to simulate a failure. Then it calls rollEditLogs() to trigger the deleted dir to be used and fail with an IOException. Unfortunately, deleting the shared dir can put the NN in safe mode due to lack of space. This causes a SafeModeException to be thrown when rollEditDirs() is called. This exception is caught as an IOException in the test but the associated assert in the catch block fails.
> This always happens in the debugger because the delay in stepping through causes the safe mode change to happen before rollEditLogs() gets called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2915) HA:
TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
Posted by "Bikas Saha (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bikas Saha updated HDFS-2915:
-----------------------------
Attachment: HDFS-2915.HDFS-1623.patch
Attaching a patch that replaces shared dir delete with shared dir write permissions revoked. This removes the race with safe mode.
> HA: TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
> ----------------------------------------------------------------------
>
> Key: HDFS-2915
> URL: https://issues.apache.org/jira/browse/HDFS-2915
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Priority: Minor
> Attachments: HDFS-2915.HDFS-1623.patch
>
>
> The test deletes the shared edits dir to simulate a failure. Then it calls rollEditLogs() to trigger the deleted dir to be used and fail with an IOException. Unfortunately, deleting the shared dir can put the NN in safe mode due to lack of space. This causes a SafeModeException to be thrown when rollEditDirs() is called. This exception is caught as an IOException in the test but the associated assert in the catch block fails.
> This always happens in the debugger because the delay in stepping through causes the safe mode change to happen before rollEditLogs() gets called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2915) HA:
TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
Posted by "Bikas Saha (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203838#comment-13203838 ]
Bikas Saha commented on HDFS-2915:
----------------------------------
I am planning to make the shared dir inaccessible by changing write permissions (instead of deleting the directory). That gets rid all potential race conditions.
> HA: TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
> ----------------------------------------------------------------------
>
> Key: HDFS-2915
> URL: https://issues.apache.org/jira/browse/HDFS-2915
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Priority: Minor
>
> The test deletes the shared edits dir to simulate a failure. Then it calls rollEditLogs() to trigger the deleted dir to be used and fail with an IOException. Unfortunately, deleting the shared dir can put the NN in safe mode due to lack of space. This causes a SafeModeException to be thrown when rollEditDirs() is called. This exception is caught as an IOException in the test but the associated assert in the catch block fails.
> This always happens in the debugger because the delay in stepping through causes the safe mode change to happen before rollEditLogs() gets called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2915) HA:
TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
Posted by "Bikas Saha (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204916#comment-13204916 ]
Bikas Saha commented on HDFS-2915:
----------------------------------
Let me address these in the patch for HDFS-2912 which modifies the same test.
> HA: TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
> ----------------------------------------------------------------------
>
> Key: HDFS-2915
> URL: https://issues.apache.org/jira/browse/HDFS-2915
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Priority: Minor
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2915.HDFS-1623.patch, HDFS-2915.HDFS-1623.patch
>
>
> The test deletes the shared edits dir to simulate a failure. Then it calls rollEditLogs() to trigger the deleted dir to be used and fail with an IOException. Unfortunately, deleting the shared dir can put the NN in safe mode due to lack of space. This causes a SafeModeException to be thrown when rollEditDirs() is called. This exception is caught as an IOException in the test but the associated assert in the catch block fails.
> This always happens in the debugger because the delay in stepping through causes the safe mode change to happen before rollEditLogs() gets called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HDFS-2915) HA:
TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
Posted by "Jitendra Nath Pandey (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey resolved HDFS-2915.
----------------------------------------
Resolution: Fixed
Fix Version/s: HA branch (HDFS-1623)
Hadoop Flags: Reviewed
Committed. Thanks to Bikas!
> HA: TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
> ----------------------------------------------------------------------
>
> Key: HDFS-2915
> URL: https://issues.apache.org/jira/browse/HDFS-2915
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Priority: Minor
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2915.HDFS-1623.patch, HDFS-2915.HDFS-1623.patch
>
>
> The test deletes the shared edits dir to simulate a failure. Then it calls rollEditLogs() to trigger the deleted dir to be used and fail with an IOException. Unfortunately, deleting the shared dir can put the NN in safe mode due to lack of space. This causes a SafeModeException to be thrown when rollEditDirs() is called. This exception is caught as an IOException in the test but the associated assert in the catch block fails.
> This always happens in the debugger because the delay in stepping through causes the safe mode change to happen before rollEditLogs() gets called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2915) HA:
TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203763#comment-13203763 ]
Aaron T. Myers commented on HDFS-2915:
--------------------------------------
bq. I think after addressing HDFS-2914, this problem should not be there right?
Not necessarily. Depends upon how HDFS-2914 is addressed.
I think a fine solution for this issue would just be to set the {{dfs.namenode.resource.check.interval}} very high in the test. It defaults to 5 seconds.
> HA: TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
> ----------------------------------------------------------------------
>
> Key: HDFS-2915
> URL: https://issues.apache.org/jira/browse/HDFS-2915
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Priority: Minor
>
> The test deletes the shared edits dir to simulate a failure. Then it calls rollEditLogs() to trigger the deleted dir to be used and fail with an IOException. Unfortunately, deleting the shared dir can put the NN in safe mode due to lack of space. This causes a SafeModeException to be thrown when rollEditDirs() is called. This exception is caught as an IOException in the test but the associated assert in the catch block fails.
> This always happens in the debugger because the delay in stepping through causes the safe mode change to happen before rollEditLogs() gets called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2915) HA:
TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
Posted by "Aaron T. Myers (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204921#comment-13204921 ]
Aaron T. Myers commented on HDFS-2915:
--------------------------------------
bq. Let me address these in the patch for HDFS-2912 which modifies the same test.
Sounds good.
> HA: TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
> ----------------------------------------------------------------------
>
> Key: HDFS-2915
> URL: https://issues.apache.org/jira/browse/HDFS-2915
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Priority: Minor
> Fix For: HA branch (HDFS-1623)
>
> Attachments: HDFS-2915.HDFS-1623.patch, HDFS-2915.HDFS-1623.patch
>
>
> The test deletes the shared edits dir to simulate a failure. Then it calls rollEditLogs() to trigger the deleted dir to be used and fail with an IOException. Unfortunately, deleting the shared dir can put the NN in safe mode due to lack of space. This causes a SafeModeException to be thrown when rollEditDirs() is called. This exception is caught as an IOException in the test but the associated assert in the catch block fails.
> This always happens in the debugger because the delay in stepping through causes the safe mode change to happen before rollEditLogs() gets called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2915) HA:
TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203410#comment-13203410 ]
Uma Maheswara Rao G commented on HDFS-2915:
-------------------------------------------
I think after addressing HDFS-2914, this problem should not be there right?
> HA: TestFailureOfSharedDir.testFailureOfSharedDir() has race condition
> ----------------------------------------------------------------------
>
> Key: HDFS-2915
> URL: https://issues.apache.org/jira/browse/HDFS-2915
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: HA branch (HDFS-1623)
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Priority: Minor
>
> The test deletes the shared edits dir to simulate a failure. Then it calls rollEditLogs() to trigger the deleted dir to be used and fail with an IOException. Unfortunately, deleting the shared dir can put the NN in safe mode due to lack of space. This causes a SafeModeException to be thrown when rollEditDirs() is called. This exception is caught as an IOException in the test but the associated assert in the catch block fails.
> This always happens in the debugger because the delay in stepping through causes the safe mode change to happen before rollEditLogs() gets called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira