Re: [PR] [MCOMPILER-592] - IndexOutOfBoundsException when project.build.output… [maven-compiler-plugin]

["thijsrijpert (via GitHub)" <gi...@apache.org>]

thijsrijpert commented on code in PR #244:
URL: https://github.com/apache/maven-compiler-plugin/pull/244#discussion_r1639665121


##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -1239,7 +1239,9 @@ public void execute() throws MojoExecutionException, CompilationFailureException
             }
         }
 
-        if (outputTimestamp != null && (outputTimestamp.length() > 1 || Character.isDigit(outputTimestamp.charAt(0)))) {
+        if (outputTimestamp != null
+                && !outputTimestamp.isEmpty()

Review Comment:
   Hi I looked a bit further into this. 
   
   In the (internal) project I was working on was using the jgitver maven extension. This extension has a field named COMMIT_ISO_TIMESTAMP which contains the timestamp of the commit. If the repository does not have any commits, this timestamp is empty. The project I was working on was mapping this timestamp to the project.build.outputTimestamp to this maven commit timestamp in the parent pom, which I missed before.
   
   This caused the above mentioned compiler error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org