You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/09/15 13:48:15 UTC

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6124: Role and User struct changes for permission based roles

ocket8888 commented on a change in pull request #6124:
URL: https://github.com/apache/trafficcontrol/pull/6124#discussion_r709204410



##########
File path: lib/go-tc/roles.go
##########
@@ -19,6 +28,70 @@ package tc
  * under the License.
  */
 
+// RoleV5 is an alias for RoleV50.

Review comment:
       While this is technically true, the purpose of the alias is to always point to the latest minor version for its associated major version.

##########
File path: lib/go-tc/roles.go
##########
@@ -19,6 +28,70 @@ package tc
  * under the License.
  */
 
+// RoleV5 is an alias for RoleV50.
+type RoleV5 RoleV50
+
+// RolesResponseV5 is a list of RoleV50 as a response.
+type RolesResponseV5 struct {
+	Response []RoleV5 `json:"response"`
+	Alerts
+}
+
+// RoleResponseV5 is a RoleV50 as a response.

Review comment:
       Nit but these are actually `RoleV5`s as responses.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org