[GitHub] [iceberg] rdblue commented on a change in pull request #1395: Changes default collect behavior of ExpireSnapshotActions

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1395:
URL: https://github.com/apache/iceberg/pull/1395#discussion_r478664931



##########
File path: spark/src/main/java/org/apache/iceberg/actions/ExpireSnapshotsAction.java
##########
@@ -90,6 +91,19 @@ protected Table table() {
     return table;
   }
 
+  /**
+   * Whether or not to use stream the expired file list to the driver. The default (false) will use
+   * collect to bring back all results to the driver at once which may be an issue with very long file lists.

Review comment:
       Sounds good to me, except that it creates a dead link because `Dataset#toLocalIterator` is not in Iceberg Javadoc.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org