You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2025/03/03 12:52:13 UTC
(commons-io) branch master updated (bfeb77420 -> a7cf506dd)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git
from bfeb77420 Fix test fixture
new d821156ca Test fixture doesn't need to be public
new 454e73db2 Revert to original test fixture size
new a7cf506dd Add missing argument in test
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
src/test/java/org/apache/commons/io/channels/FileChannelsTest.java | 4 ++--
.../org/apache/commons/io/channels/NonBlockingFileChannelProxy.java | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
(commons-io) 01/03: Test fixture doesn't need to be public
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git
commit d821156cad6859e14c34e140fa918fad290a8319
Author: Gary D. Gregory <ga...@gmail.com>
AuthorDate: Mon Mar 3 07:45:32 2025 -0500
Test fixture doesn't need to be public
---
.../org/apache/commons/io/channels/NonBlockingFileChannelProxy.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/test/java/org/apache/commons/io/channels/NonBlockingFileChannelProxy.java b/src/test/java/org/apache/commons/io/channels/NonBlockingFileChannelProxy.java
index 31ec1fe93..c88cfa854 100644
--- a/src/test/java/org/apache/commons/io/channels/NonBlockingFileChannelProxy.java
+++ b/src/test/java/org/apache/commons/io/channels/NonBlockingFileChannelProxy.java
@@ -25,7 +25,7 @@
/**
* Simulates a non-blocking file channel by returning 0 from reads every other call as allowed by {@link ReadableByteChannel} and {@link FileChannel}.
*/
-public class NonBlockingFileChannelProxy extends FileChannelProxy {
+class NonBlockingFileChannelProxy extends FileChannelProxy {
boolean toggleRead0;
(commons-io) 02/03: Revert to original test fixture size
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git
commit 454e73db216abf1cc8bdb87a10879781fbc78dd5
Author: Gary D. Gregory <ga...@gmail.com>
AuthorDate: Mon Mar 3 07:46:19 2025 -0500
Revert to original test fixture size
---
src/test/java/org/apache/commons/io/channels/FileChannelsTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/test/java/org/apache/commons/io/channels/FileChannelsTest.java b/src/test/java/org/apache/commons/io/channels/FileChannelsTest.java
index f9ee13449..3ca0a2ecc 100644
--- a/src/test/java/org/apache/commons/io/channels/FileChannelsTest.java
+++ b/src/test/java/org/apache/commons/io/channels/FileChannelsTest.java
@@ -85,7 +85,7 @@ public void testContentEquals(
final Path bigFile3 = Files.createTempFile(getClass().getSimpleName(), "-3.bin");
try {
// This length must match any restriction from the Surefire configuration.
- final int newLength = 2_000_000;
+ final int newLength = 1_000_000;
final byte[] bytes1 = new byte[newLength];
final byte[] bytes2 = new byte[newLength];
// Make sure bytes1 and bytes2 are different despite the shuffle
(commons-io) 03/03: Add missing argument in test
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-io.git
commit a7cf506dd5ca19d522c2a87470ad94f126a5537b
Author: Gary D. Gregory <ga...@gmail.com>
AuthorDate: Mon Mar 3 07:52:09 2025 -0500
Add missing argument in test
---
src/test/java/org/apache/commons/io/channels/FileChannelsTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/test/java/org/apache/commons/io/channels/FileChannelsTest.java b/src/test/java/org/apache/commons/io/channels/FileChannelsTest.java
index 3ca0a2ecc..fecc70a58 100644
--- a/src/test/java/org/apache/commons/io/channels/FileChannelsTest.java
+++ b/src/test/java/org/apache/commons/io/channels/FileChannelsTest.java
@@ -105,7 +105,7 @@ public void testContentEquals(
final int last = bytes3.length - 1;
bytes3[last] = reverse(bytes3[last]);
Files.write(bigFile3, bytes3);
- try (FileChannel fc1 = open(bigFile1, null); FileChannel fc3 = open(bigFile3, fileChannelType2)) {
+ try (FileChannel fc1 = open(bigFile1, fileChannelType1); FileChannel fc3 = open(bigFile3, fileChannelType2)) {
assertFalse(FileChannels.contentEquals(fc1, fc3, bufferSize));
assertFalse(FileChannels.contentEquals(reset(fc3), reset(fc1), bufferSize));
// Test just the last byte