[GitHub] [nifi] ChrisSamo632 commented on a diff in pull request #6797: NIFI-10992 - Option to build all include-x profiles

[GitBox <gi...@apache.org>]

ChrisSamo632 commented on code in PR #6797:
URL: https://github.com/apache/nifi/pull/6797#discussion_r1059090649


##########
nifi-assembly/pom.xml:
##########
@@ -983,6 +983,9 @@ language governing permissions and limitations under the License. -->
             <id>include-graph</id>
             <activation>
                 <activeByDefault>false</activeByDefault>
+                <property>
+                    <name>allProfiles</name>

Review Comment:
   Could `allProfiles` be set as a peppery as part of a new profile, e.g. a profile called `include-all` that just contains a
   
   ```xml
   <properties>
     <allProfiles>true</allProfiles>
   </properties>
   ```
   
   Block? That way we can still use the `mvn -p` profile flag instead of `-D` setting, which may be a bit more obvious for people
   
   I haven't tried this though so don't know whether the profiles dependency/linking would work



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org