You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "Cole-Greer (via GitHub)" <gi...@apache.org> on 2024/10/16 01:36:32 UTC
[PR] [TINKERPOP-3076] Throw better error if request exceeds WriteBufferSize in Go [tinkerpop]
Cole-Greer opened a new pull request, #2834:
URL: https://github.com/apache/tinkerpop/pull/2834
Gorilla has an implicit frame size limit imposed by WriteBufferSize. Requests which exceed this limit cannot be parsed by gremlin server and currently lead to cryptic errors in the server. This PR simply adds a client side check to throw a more descriptive error to the user. The resulting behaviour is very similar to how `maxContentLength` functions in the java driver.
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3076] Throw better error if request exceeds WriteBufferSize in Go [tinkerpop]
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2834:
URL: https://github.com/apache/tinkerpop/pull/2834#issuecomment-2418039153
VOTE+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3076] Throw better error if request exceeds WriteBufferSize in Go [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer merged PR #2834:
URL: https://github.com/apache/tinkerpop/pull/2834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3076] Throw better error if request exceeds WriteBufferSize in Go [tinkerpop]
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #2834:
URL: https://github.com/apache/tinkerpop/pull/2834#issuecomment-2418008776
You should add an actual English error message to `en.json`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3076] Throw better error if request exceeds WriteBufferSize in Go [tinkerpop]
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #2834:
URL: https://github.com/apache/tinkerpop/pull/2834#issuecomment-2418121179
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3076] Throw better error if request exceeds WriteBufferSize in Go [tinkerpop]
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #2834:
URL: https://github.com/apache/tinkerpop/pull/2834#issuecomment-2418132793
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TINKERPOP-3076] Throw better error if request exceeds WriteBufferSize in Go [tinkerpop]
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on code in PR #2834:
URL: https://github.com/apache/tinkerpop/pull/2834#discussion_r1802224172
##########
gremlin-go/driver/gorillaTransporter.go:
##########
@@ -100,6 +101,9 @@ func (transporter *gorillaTransporter) Write(data []byte) error {
return err
}
}
+ if len(data) > transporter.connSettings.writeBufferSize {
+ return errors.New("request too large, consider increasing 'WriteBufferSize' configuration or split into smaller requests")
Review Comment:
all errors should be defined in `error_codes.go`
and used like `return newError(err0101ConnectionCloseError)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org