You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/02/21 12:17:40 UTC

Review Request 56882: Unique Name not created automatically when designing workflow

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56882/
-----------------------------------------------------------

Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.


Bugs: AMBARI-20095
    https://issues.apache.org/jira/browse/AMBARI-20095


Repository: ambari


Description
-------

Create a workflow
Keep adding actions and WFD shows error saying that node name should be unique.


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 190bb1a 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js a563c20 

Diff: https://reviews.apache.org/r/56882/diff/


Testing
-------

Manual Testing done


Thanks,

venkat sairam


Re: Review Request 56882: Unique Name not created automatically when designing workflow

Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56882/#review166154
-----------------------------------------------------------


Ship it!




Ship It!

- belliraj hb


On Feb. 21, 2017, 12:17 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56882/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2017, 12:17 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20095
>     https://issues.apache.org/jira/browse/AMBARI-20095
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create a workflow
> Keep adding actions and WFD shows error saying that node name should be unique.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 190bb1a 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js a563c20 
> 
> Diff: https://reviews.apache.org/r/56882/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>


Re: Review Request 56882: Unique Name not created automatically when designing workflow

Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56882/#review166157
-----------------------------------------------------------


Ship it!




Ship It!

- Nitiraj Rathore


On Feb. 21, 2017, 12:17 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56882/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2017, 12:17 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20095
>     https://issues.apache.org/jira/browse/AMBARI-20095
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create a workflow
> Keep adding actions and WFD shows error saying that node name should be unique.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 190bb1a 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js a563c20 
> 
> Diff: https://reviews.apache.org/r/56882/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>


Re: Review Request 56882: Unique Name not created automatically when designing workflow

Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56882/#review166169
-----------------------------------------------------------


Ship it!




Ship It!

- Pallav Kulshreshtha


On Feb. 21, 2017, 12:17 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56882/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2017, 12:17 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20095
>     https://issues.apache.org/jira/browse/AMBARI-20095
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create a workflow
> Keep adding actions and WFD shows error saying that node name should be unique.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 190bb1a 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js a563c20 
> 
> Diff: https://reviews.apache.org/r/56882/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>