You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "liang-wenjie (via GitHub)" <gi...@apache.org> on 2026/08/12 06:38:47 UTC
[PR] feat: add interval trigger type for schedules [dolphinscheduler]
liang-wenjie opened a new pull request, #18548:
URL: https://github.com/apache/dolphinscheduler/pull/18548
## What is changed
Add an independent interval trigger type for workflow schedules.
- Support CRON and INTERVAL trigger types.
- Represent interval schedules as JSON with hour, minute, second, and repeat fields.
- Support finite execution counts and unlimited repetition (`repeat = -1`).
- Use Quartz SimpleTrigger for interval schedules and honor the existing missed-fire policy.
- Generate interval-based preview times and expose interval configuration in the UI.
- Add database initialization and 3.5.0 upgrade columns for `trigger_type`.
## Why is this needed
For interval scheduling, when executions overlap or a previous run is still active, the next fire time should continue to be calculated from the configured interval, with an optional execution count limit.
## Tests
- `mvnw -B -pl dolphinscheduler-scheduler-plugin/dolphinscheduler-scheduler-quartz -am -DskipTests=true -Dspotless.skip=true -DskipUT=true -Djacoco.skip=true -Danalyze.skip=true compile`
- `git diff --check`
The broader API reactor build was attempted but stopped in an unrelated `dolphinscheduler-datasource-starrocks` remote-resource failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-18550] Add interval trigger type for schedules [dolphinscheduler]
Posted by "liang-wenjie (via GitHub)" <gi...@apache.org>.
liang-wenjie commented on PR #18548:
URL: https://github.com/apache/dolphinscheduler/pull/18548#issuecomment-5312426962
Addressed the requested e2e coverage in commit 972aa48a8. SchedulerAPITest now creates, queries, updates, and verifies persistence of INTERVAL schedules, including triggerType=INTERVAL. The api-test module was compile-checked; local execution is blocked by the existing Java 8 runtime while junit-pioneer 2.2.0 requires Java 11 (class version 55).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-18550] Add interval trigger type for schedules [dolphinscheduler]
Posted by "liang-wenjie (via GitHub)" <gi...@apache.org>.
liang-wenjie commented on PR #18548:
URL: https://github.com/apache/dolphinscheduler/pull/18548#issuecomment-5404893077
> The description of PR is still messy.
Thanks for the feedback.
I have cleaned up the PR description and organized it into Summary, Changes, and Validation sections.
I also manually reviewed the latest changes, including the `triggerType` persistence fix and the interval schedule API test coverage. The schedule payload now includes `triggerType` inside the `schedule` JSON for both create and update requests.
Please take another look when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-18550] Add interval trigger type for schedules [dolphinscheduler]
Posted by "liang-wenjie (via GitHub)" <gi...@apache.org>.
liang-wenjie commented on PR #18548:
URL: https://github.com/apache/dolphinscheduler/pull/18548#issuecomment-5336311451
I have manually reviewed the AI-assisted changes locally and will push the follow-up fixes shortly.
The follow-up fixes have now been pushed in commit `f48a528139565d103d2b64e76af5c2e3f3996632`.
The changes include:
- preserving an existing `INTERVAL` trigger type when `triggerType` is omitted during update;
- rejecting an explicit `null` trigger type;
- validating interval expressions by requiring `repeat` and restricting `minute` / `second` to `0-59`;
- adding service-layer and Quartz `SimpleTrigger` regression tests;
- fixing the Spotless formatting issue in `SchedulerAPITest`.
Local verification passed:
- `SchedulerServiceTest`: 18 tests, 0 failures, 0 errors;
- `QuartzSimpleTriggerBuilderTest`: 2 tests, 0 failures, 0 errors.
Please take another look when convenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-18550] Add interval trigger type for schedules [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on PR #18548:
URL: https://github.com/apache/dolphinscheduler/pull/18548#issuecomment-5403788787
The description of PR is still messy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-18550] Add interval trigger type for schedules [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS closed pull request #18548: [Feature-18550] Add interval trigger type for schedules
URL: https://github.com/apache/dolphinscheduler/pull/18548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-18550] Add interval trigger type for schedules [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on PR #18548:
URL: https://github.com/apache/dolphinscheduler/pull/18548#issuecomment-6228148983
Closing this PR for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org