You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2022/12/01 05:05:14 UTC
[GitHub] [incubator-pekko] gmethvin opened a new pull request, #63: Rename akka to pekko in configuration
gmethvin opened a new pull request, #63:
URL: https://github.com/apache/incubator-pekko/pull/63
Resolves #54
Rename `akka` in configuration to `pekko`, and update the code to use the new keys.
This changes a very large number of files, so like with #58, you probably want to check out the branch and look at it in a good diff tool.
This was mostly done as a bunch of different find/replace operations to match things that look like config paths.
This does not attempt to address issues for users migrating from akka to pekko config. We can follow up with any compatibility changes in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] gmethvin merged pull request #63: Rename akka to pekko in configuration
Posted by GitBox <gi...@apache.org>.
gmethvin merged PR #63:
URL: https://github.com/apache/incubator-pekko/pull/63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #63: Rename akka to pekko in configuration
Posted by GitBox <gi...@apache.org>.
pjfanning commented on code in PR #63:
URL: https://github.com/apache/incubator-pekko/pull/63#discussion_r1036885208
##########
project/VersionGenerator.scala:
##########
@@ -8,15 +8,15 @@ import sbt._
import sbt.Keys._
/**
- * Generate version.conf and akka/Version.scala files based on the version setting.
+ * Generate version.conf and Version.scala files based on the version setting.
Review Comment:
should this file be generated as org/apache/pekko/Version.scala?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] gmethvin commented on pull request #63: Rename akka to pekko in configuration
Posted by GitBox <gi...@apache.org>.
gmethvin commented on PR #63:
URL: https://github.com/apache/incubator-pekko/pull/63#issuecomment-1334719270
@mdedetrich CI is passing now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #63: Rename akka to pekko in configuration
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #63:
URL: https://github.com/apache/incubator-pekko/pull/63#issuecomment-1333810593
> @gmethvin The CI is failing
failed mima binary checks - I thought they were disabled in main branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] gmethvin commented on pull request #63: Rename akka to pekko in configuration
Posted by GitBox <gi...@apache.org>.
gmethvin commented on PR #63:
URL: https://github.com/apache/incubator-pekko/pull/63#issuecomment-1335185478
I'm going to go ahead and merge this. If I missed some things we can work them out later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #63: Rename akka to pekko in configuration
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #63:
URL: https://github.com/apache/incubator-pekko/pull/63#issuecomment-1335003407
@gmethvin I merged my changes. I wasn't aware how many docs files you had changed. Could you have a look to see if this PR can be easily fixed up? If it is too problematic, I could look at reverting my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] gmethvin commented on a diff in pull request #63: Rename akka to pekko in configuration
Posted by GitBox <gi...@apache.org>.
gmethvin commented on code in PR #63:
URL: https://github.com/apache/incubator-pekko/pull/63#discussion_r1036890138
##########
project/VersionGenerator.scala:
##########
@@ -8,15 +8,15 @@ import sbt._
import sbt.Keys._
/**
- * Generate version.conf and akka/Version.scala files based on the version setting.
+ * Generate version.conf and Version.scala files based on the version setting.
Review Comment:
I think only the package name really matters in this case, right? This is just generated code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #63: Rename akka to pekko in configuration
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #63:
URL: https://github.com/apache/incubator-pekko/pull/63#issuecomment-1333480727
Also project/MultiNode.scala - `sys.props.getOrElse("akka.test.multi-in-test", "true")` needs to change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #63: Rename akka to pekko in configuration
Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #63:
URL: https://github.com/apache/incubator-pekko/pull/63#issuecomment-1333506572
> @pjfanning thanks, I may have missed a few things in the build. I'd like this PR to include both system properties and HOCON configuration, so those are all valid changes.
I've hit hit similar issues in some of my PRs. IntelliJ seems to ignore the project dir when doing global replaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] gmethvin commented on a diff in pull request #63: Rename akka to pekko in configuration
Posted by GitBox <gi...@apache.org>.
gmethvin commented on code in PR #63:
URL: https://github.com/apache/incubator-pekko/pull/63#discussion_r1036904761
##########
project/VersionGenerator.scala:
##########
@@ -8,15 +8,15 @@ import sbt._
import sbt.Keys._
/**
- * Generate version.conf and akka/Version.scala files based on the version setting.
+ * Generate version.conf and Version.scala files based on the version setting.
Review Comment:
I'll just change it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] gmethvin commented on pull request #63: Rename akka to pekko in configuration
Posted by GitBox <gi...@apache.org>.
gmethvin commented on PR #63:
URL: https://github.com/apache/incubator-pekko/pull/63#issuecomment-1333496741
@pjfanning thanks, I may have missed a few things in the build. I'd like this PR to include both system properties and HOCON configuration, so those are all valid changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #63: Rename akka to pekko in configuration
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #63:
URL: https://github.com/apache/incubator-pekko/pull/63#issuecomment-1333459391
Thanks for the PR, will try to get this checked out by the weekend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #63: Rename akka to pekko in configuration
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #63:
URL: https://github.com/apache/incubator-pekko/pull/63#issuecomment-1333797726
@gmethvin The CI is failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #63: Rename akka to pekko in configuration
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #63:
URL: https://github.com/apache/incubator-pekko/pull/63#issuecomment-1333994513
@gmethvin The PR at #65 has been merged into main, can you rebase this PR to see if CI passes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #63: Rename akka to pekko in configuration
Posted by GitBox <gi...@apache.org>.
pjfanning commented on code in PR #63:
URL: https://github.com/apache/incubator-pekko/pull/63#discussion_r1036899683
##########
project/VersionGenerator.scala:
##########
@@ -8,15 +8,15 @@ import sbt._
import sbt.Keys._
/**
- * Generate version.conf and akka/Version.scala files based on the version setting.
+ * Generate version.conf and Version.scala files based on the version setting.
Review Comment:
other unrelated jars on a project's classpath could have Version classes as well - I think it is better to put this class in a pekko specific package - the akka Version class is in the akka package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org