You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "hartmannathan (via GitHub)" <gi...@apache.org> on 2024/01/02 14:05:59 UTC

Re: [PR] support sorting symbol tables by name [nuttx]

hartmannathan commented on code in PR #11448:
URL: https://github.com/apache/nuttx/pull/11448#discussion_r1439479722


##########
libs/libc/symtab/symtab_findbyvalue.c:
##########
@@ -92,7 +92,7 @@ symtab_findbyvalue(FAR const struct symtab_s *symtab,
         }
       else if (symtab[mid].sym_value < value)
         {
-          if (symtab[mid + 1].sym_value >= value)
+          if (symtab[mid + 1].sym_value > value)

Review Comment:
   Agreed this needs to be checked



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org