You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/16 19:33:45 UTC

[GitHub] [incubator-tvm] areusch opened a new pull request #6499: Switch CRC-CCITT libraries

areusch opened a new pull request #6499:
URL: https://github.com/apache/incubator-tvm/pull/6499


   Fixes #6496. 
   
   I found an MIT-licensed library that was fairly easy to adapt, but I had to make some changes on top of the pristine import. I feel like we normally use submodule, but given changes were needed, imported with subtree and patched on top. let me know if you prefer a different approach.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] cbalint13 edited a comment on pull request #6499: Switch CRC-CCITT libraries

Posted by GitBox <gi...@apache.org>.
cbalint13 edited a comment on pull request #6499:
URL: https://github.com/apache/incubator-tvm/pull/6499#issuecomment-694148041


   @areusch h , @tqchen 
   
   Wouldn't be better to use boost's crc  ?
   https://www.boost.org/doc/libs/1_74_0/doc/html/crc.html
   https://stackoverflow.com/questions/36732949/boost-crc-16-bit
   
   * We could only add boost detection to actual cmake flow and just use it.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] areusch commented on pull request #6499: Switch CRC-CCITT libraries

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #6499:
URL: https://github.com/apache/incubator-tvm/pull/6499#issuecomment-693766986


   ugh, fixed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #6499: Switch CRC-CCITT libraries

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6499:
URL: https://github.com/apache/incubator-tvm/pull/6499#issuecomment-694295308


   Thansk @cbalint13 I believe the main concern here is the need for a minimum C impl for micro controllers, so boost/llvm cannot be used in this case. Although the most ideal case might be a mininum impl in the uTVM source. I am going to merge this for now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] cbalint13 removed a comment on pull request #6499: Switch CRC-CCITT libraries

Posted by GitBox <gi...@apache.org>.
cbalint13 removed a comment on pull request #6499:
URL: https://github.com/apache/incubator-tvm/pull/6499#issuecomment-694148041


   @areusch  , @tqchen 
   
   Wouldn't be better to use boost's crc  ?
   https://www.boost.org/doc/libs/1_74_0/doc/html/crc.html
   https://stackoverflow.com/questions/36732949/boost-crc-16-bit
   
   * We could only add boost detection to actual cmake flow and just use it.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] cbalint13 edited a comment on pull request #6499: Switch CRC-CCITT libraries

Posted by GitBox <gi...@apache.org>.
cbalint13 edited a comment on pull request #6499:
URL: https://github.com/apache/incubator-tvm/pull/6499#issuecomment-694148041


   @areusch  , @tqchen 
   
   Wouldn't be better to use boost's crc  ?
   https://www.boost.org/doc/libs/1_74_0/doc/html/crc.html
   https://stackoverflow.com/questions/36732949/boost-crc-16-bit
   
   * We could only add boost detection to actual cmake flow and just use it.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] areusch commented on pull request #6499: Switch CRC-CCITT libraries

Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #6499:
URL: https://github.com/apache/incubator-tvm/pull/6499#issuecomment-693621267


   cc @tqchen 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #6499: Switch CRC-CCITT libraries

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6499:
URL: https://github.com/apache/incubator-tvm/pull/6499#issuecomment-693762068


   @areusch the vta-hw update might be unintended, please use git submodule update to point to the upstream code


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen merged pull request #6499: Switch CRC-CCITT libraries

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6499:
URL: https://github.com/apache/incubator-tvm/pull/6499


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] cbalint13 commented on pull request #6499: Switch CRC-CCITT libraries

Posted by GitBox <gi...@apache.org>.
cbalint13 commented on pull request #6499:
URL: https://github.com/apache/incubator-tvm/pull/6499#issuecomment-694148041


   @areush, @tqchen 
   
   Wouldn't be better to use boost's crc  ?
   https://www.boost.org/doc/libs/1_74_0/doc/html/crc.html
   https://stackoverflow.com/questions/36732949/boost-crc-16-bit
   
   * We could only add boost detection to actual cmake flow and just use it.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org