[GitHub] [apisix] Firstsawyou commented on a change in pull request #3637: fix: we should ensure one upstream only have one determinable scheme

[GitBox <gi...@apache.org>]

Firstsawyou commented on a change in pull request #3637:
URL: https://github.com/apache/apisix/pull/3637#discussion_r580807083



##########
File path: doc/plugins/proxy-rewrite.md
##########
@@ -35,7 +35,7 @@ The `proxy-rewrite` is an upstream proxy information rewriting plugin, which sup
 
 | Name      | Type          | Requirement | Default | Valid             | Description                                                  |
 | --------- | ------------- | ----------- | ------- | ----------------- | ------------------------------------------------------------ |
-| scheme    | string        | optional    | "http"  | ["http", "https"] | Upstream new `schema` forwarding protocol.                   |
+| scheme    | string        | optional    | "http"  | ["http", "https"] | Deprecated. It's recommended to set the proxy `scheme` in the Upstream object's `scheme` field instead.|

Review comment:
       I think in the `Description` part, a description should be added or the original description should be retained.
   such as:  
   Upstream new `schema` forwarding protocol (Deprecated. It's recommended to set the proxy `scheme` in the Upstream object's `scheme` field instead).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org