You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2023/05/26 15:05:53 UTC

[GitHub] [beam] Abacn opened a new pull request, #26908: Provide Python container path in xlang postcommit

Abacn opened a new pull request, #26908:
URL: https://github.com/apache/beam/pull/26908

   Fixes #26907
   
   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26908: Provide Python container path in xlang postcommit

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26908:
URL: https://github.com/apache/beam/pull/26908#issuecomment-1564678798

   Run Python_Xlang_Gcp_Dataflow PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26908: Provide Python container path in xlang postcommit

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26908:
URL: https://github.com/apache/beam/pull/26908#issuecomment-1564628272

   Run Python_Xlang_Gcp_Dataflow PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #26908: Provide Python container path in xlang postcommit

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #26908:
URL: https://github.com/apache/beam/pull/26908#discussion_r1207085113


##########
sdks/python/test-suites/dataflow/common.gradle:
##########
@@ -458,7 +458,8 @@ project(":sdks:python:test-suites:xlang").ext.xlangTasks.each { taskMetadata ->
         "--runner=TestDataflowRunner",
         "--project=${dataflowProject}",
         "--region=${dataflowRegion}",
-        "--sdk_harness_container_image_overrides=.*java.*,gcr.io/apache-beam-testing/beam-sdk/beam_java8_sdk:latest"
+        "--sdk_harness_container_image_overrides=.*java.*,gcr.io/apache-beam-testing/beam-sdk/beam_java8_sdk:latest",
+        "--sdk_harness_container_image_overrides=.*python.*,gcr.io/apache-beam-testing/beam-sdk/beam_python${project.ext.pythonVersion}_sdk:latest"

Review Comment:
   done (both are equivalent in this case)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn merged pull request #26908: Provide Python container path in xlang postcommit

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #26908:
URL: https://github.com/apache/beam/pull/26908


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #26908: Provide Python container path in xlang postcommit

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #26908:
URL: https://github.com/apache/beam/pull/26908#discussion_r1207068719


##########
.test-infra/jenkins/job_PostCommit_Python_CrossLanguage_Gcp_Direct.groovy:
##########
@@ -44,7 +44,6 @@ PostcommitJobBuilder.postCommitJob('beam_PostCommit_Python_Xlang_Gcp_Direct',
           rootBuildScriptDir(commonJobProperties.checkoutDir)
           tasks(":sdks:python:test-suites:direct:gcpCrossLanguagePostCommit")
           commonJobProperties.setGradleSwitches(delegate)
-          switches("-PuseWheelDistribution")

Review Comment:
   This flag was not effective at the first place. It's Direct runner, and the flag only affects dataflow runner



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ahmedabu98 commented on a diff in pull request #26908: Provide Python container path in xlang postcommit

Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on code in PR #26908:
URL: https://github.com/apache/beam/pull/26908#discussion_r1207066082


##########
.test-infra/jenkins/job_PostCommit_Python_CrossLanguage_Gcp_Direct.groovy:
##########
@@ -44,7 +44,6 @@ PostcommitJobBuilder.postCommitJob('beam_PostCommit_Python_Xlang_Gcp_Direct',
           rootBuildScriptDir(commonJobProperties.checkoutDir)
           tasks(":sdks:python:test-suites:direct:gcpCrossLanguagePostCommit")
           commonJobProperties.setGradleSwitches(delegate)
-          switches("-PuseWheelDistribution")

Review Comment:
   Did you mean to leave this out?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26908: Provide Python container path in xlang postcommit

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26908:
URL: https://github.com/apache/beam/pull/26908#issuecomment-1564776429

   Java PreCommit flink test known flakes unrelated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #26908: Provide Python container path in xlang postcommit

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26908:
URL: https://github.com/apache/beam/pull/26908#issuecomment-1564554648

   ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/26908?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#26908](https://app.codecov.io/gh/apache/beam/pull/26908?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (cef6dcb) into [master](https://app.codecov.io/gh/apache/beam/commit/0b430748cdd2e25edc553747ce018195e9cce888?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0b43074) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #26908   +/-   ##
   =======================================
     Coverage   71.27%   71.27%           
   =======================================
     Files         766      766           
     Lines      103470   103470           
   =======================================
     Hits        73751    73751           
     Misses      28180    28180           
     Partials     1539     1539           
   ```
   
   
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26908: Provide Python container path in xlang postcommit

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26908:
URL: https://github.com/apache/beam/pull/26908#issuecomment-1564656836

   Now it installs sdk_location:
   
   ```
   DEBUG 2023-05-26T16:43:53.123720892Z Found artifact: apache_beam-2.49.0.dev0-cp37-cp37m-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
   INFO 2023-05-26T16:43:53.123796692Z 2023/05/26 16:43:53 Installing setup packages ...
   INFO 2023-05-26T16:43:53.125773581Z 2023/05/26 16:43:53 Found Apache Beam SDK wheel: apache_beam-2.49.0.dev0-cp37-cp37m-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
   ```
   
   and pipeline succeeded on dataflow
   
   https://pantheon.corp.google.com/dataflow/jobs/us-central1/2023-05-26_09_40_50-14635437667418421190;bottomTab=WORKER_LOGS;logsSeverity=INFO;graphView=0?project=apache-beam-testing&pageState=(%22dfTime%22:(%22l%22:%22dfJobMaxTime%22))&e=13802955&jsmode=O&mods=logs_tg_prod


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26908: Provide Python container path in xlang postcommit

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26908:
URL: https://github.com/apache/beam/pull/26908#issuecomment-1564628496

   Run Python_Xlang_Gcp_Direct PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26908: Provide Python container path in xlang postcommit

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26908:
URL: https://github.com/apache/beam/pull/26908#issuecomment-1564729418

   Run Spotless PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26908: Provide Python container path in xlang postcommit

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26908:
URL: https://github.com/apache/beam/pull/26908#issuecomment-1564729570

   Run Java_Examples_Dataflow_Java17 PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #26908: Provide Python container path in xlang postcommit

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26908:
URL: https://github.com/apache/beam/pull/26908#issuecomment-1564658011

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26908: Provide Python container path in xlang postcommit

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26908:
URL: https://github.com/apache/beam/pull/26908#issuecomment-1564533991

   Run Python_Xlang_Gcp_Dataflow PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ahmedabu98 commented on a diff in pull request #26908: Provide Python container path in xlang postcommit

Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on code in PR #26908:
URL: https://github.com/apache/beam/pull/26908#discussion_r1207068570


##########
sdks/python/test-suites/dataflow/common.gradle:
##########
@@ -458,7 +458,8 @@ project(":sdks:python:test-suites:xlang").ext.xlangTasks.each { taskMetadata ->
         "--runner=TestDataflowRunner",
         "--project=${dataflowProject}",
         "--region=${dataflowRegion}",
-        "--sdk_harness_container_image_overrides=.*java.*,gcr.io/apache-beam-testing/beam-sdk/beam_java8_sdk:latest"
+        "--sdk_harness_container_image_overrides=.*java.*,gcr.io/apache-beam-testing/beam-sdk/beam_java8_sdk:latest",
+        "--sdk_harness_container_image_overrides=.*python.*,gcr.io/apache-beam-testing/beam-sdk/beam_python${project.ext.pythonVersion}_sdk:latest"

Review Comment:
   --sdk_container_image for python container?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ahmedabu98 commented on a diff in pull request #26908: Provide Python container path in xlang postcommit

Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on code in PR #26908:
URL: https://github.com/apache/beam/pull/26908#discussion_r1207068570


##########
sdks/python/test-suites/dataflow/common.gradle:
##########
@@ -458,7 +458,8 @@ project(":sdks:python:test-suites:xlang").ext.xlangTasks.each { taskMetadata ->
         "--runner=TestDataflowRunner",
         "--project=${dataflowProject}",
         "--region=${dataflowRegion}",
-        "--sdk_harness_container_image_overrides=.*java.*,gcr.io/apache-beam-testing/beam-sdk/beam_java8_sdk:latest"
+        "--sdk_harness_container_image_overrides=.*java.*,gcr.io/apache-beam-testing/beam-sdk/beam_java8_sdk:latest",
+        "--sdk_harness_container_image_overrides=.*python.*,gcr.io/apache-beam-testing/beam-sdk/beam_python${project.ext.pythonVersion}_sdk:latest"

Review Comment:
   `--sdk_container_image` for python container?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26908: Provide Python container path in xlang postcommit

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26908:
URL: https://github.com/apache/beam/pull/26908#issuecomment-1564656950

   R: @ahmedabu98 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #26908: Provide Python container path in xlang postcommit

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #26908:
URL: https://github.com/apache/beam/pull/26908#issuecomment-1564649607

   Working for direct:
   
   before:
   
   INFO     root:environments.py:376 Default Python SDK image for environment is apache/beam_python3.8_sdk:2.49.0.dev
   
   now:
   
   12:37:59 INFO     root:environments.py:376 Default Python SDK image for environment is apache/beam_python3.7_sdk:2.49.0.dev
   
   (it should run on Py3.7 and 3.11)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org