You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/10/08 12:58:53 UTC

[GitHub] [accumulo] BukrosSzabolcs opened a new pull request #1727: Initilaize hdfs connection with correct ugi

BukrosSzabolcs opened a new pull request #1727:
URL: https://github.com/apache/accumulo/pull/1727


   ServerContext creates a ServerInfo which initializes the hdfs connection
   and among others a LeaseRenewer is started with the current
   UserGroupInformation. To make sure the correct UserGroupInformation is
   used I moved the serverLogin call before ServerContext creation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] milleruntime commented on pull request #1727: Initilaize hdfs connection with correct ugi

Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #1727:
URL: https://github.com/apache/accumulo/pull/1727#issuecomment-705694051


   It seems like the static methods in SecurityUtil should be integrated into ServerContext or ServerInfo.  One of the big efforts in the refactoring work for 2.* was to eliminate static state.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] ctubbsii edited a comment on pull request #1727: Initilaize hdfs connection with correct ugi

Posted by GitBox <gi...@apache.org>.
ctubbsii edited a comment on pull request #1727:
URL: https://github.com/apache/accumulo/pull/1727#issuecomment-705810615


   > This is probably also an issue in the Tracer:
   
   The tracer is supposed to be a client-side application. Right now, its code is intermingled with the server utilities, but it shouldn't be. Long-term, it shouldn't be using server-side login... but trying to tease it apart seems a bit more work than this simple fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] ctubbsii commented on pull request #1727: Initilaize hdfs connection with correct ugi

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1727:
URL: https://github.com/apache/accumulo/pull/1727#issuecomment-705810615


   > This is probably also an issue in the Tracer:
   > 
   > https://github.com/apache/accumulo/blob/15a95feebc74bd10e5ba73d4c2ecfc726435bc55/server/tracer/src/main/java/org/apache/accumulo/tracer/TraceServer.java#L407-L413
   
   The tracer is supposed to be a client-side application. Right now, its code is intermingled with the server utilities, but it shouldn't be. Long-term, it shouldn't be using server-side login... but trying to tease it apart seems a bit more work than this simple fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] milleruntime commented on pull request #1727: Initilaize hdfs connection with correct ugi

Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #1727:
URL: https://github.com/apache/accumulo/pull/1727#issuecomment-705697778


   This is probably also an issue in the Tracer: https://github.com/apache/accumulo/blob/15a95feebc74bd10e5ba73d4c2ecfc726435bc55/server/tracer/src/main/java/org/apache/accumulo/tracer/TraceServer.java#L407-L413


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] milleruntime commented on pull request #1727: Initilaize hdfs connection with correct ugi

Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #1727:
URL: https://github.com/apache/accumulo/pull/1727#issuecomment-705694051






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] ctubbsii commented on pull request #1727: Initilaize hdfs connection with correct ugi

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1727:
URL: https://github.com/apache/accumulo/pull/1727#issuecomment-705810615






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] ctubbsii commented on pull request #1727: Initilaize hdfs connection with correct ugi

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1727:
URL: https://github.com/apache/accumulo/pull/1727#issuecomment-705813137


   Thanks for the PR @BukrosSzabolcs . I see you've contributed once before as well, but aren't listed on our "people" page, acknowledging contributors. If you wish to be added as a contributor to https://accumulo.apache.org/people/ , please open a pull request to add yourself at https://github.com/apache/accumulo-website/edit/main/pages/people.md and leave a reference to `apache/accumulo#1727` in your commit log.
   
   If you intend to be a regular contributor to Accumulo projects, please consider subscribing to our developer mailing list (https://accumulo.apache.org/contact-us/) and introducing yourself. :smiley_cat:


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] ctubbsii merged pull request #1727: Initilaize hdfs connection with correct ugi

Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #1727:
URL: https://github.com/apache/accumulo/pull/1727


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] ctubbsii edited a comment on pull request #1727: Initilaize hdfs connection with correct ugi

Posted by GitBox <gi...@apache.org>.
ctubbsii edited a comment on pull request #1727:
URL: https://github.com/apache/accumulo/pull/1727#issuecomment-705810615


   > This is probably also an issue in the Tracer:
   
   The tracer is supposed to be a client-side application. Right now, its code is intermingled with the server utilities, but it shouldn't be. Long-term, it shouldn't be using server-side login... but trying to tease it apart seems a bit more work than this simple fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [accumulo] ctubbsii merged pull request #1727: Initilaize hdfs connection with correct ugi

Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #1727:
URL: https://github.com/apache/accumulo/pull/1727


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org