You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/09/10 00:20:50 UTC
Re: Review Request 38076: [4/5] Integer Precision for JSON <->
Protobuf conversions.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38076/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 3:20 p.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
Ready for wider review.
Summary (updated)
-----------------
[4/5] Integer Precision for JSON <-> Protobuf conversions.
Repository: mesos
Description
-------
Modify one libprocess test which originally fetched an integer as a double.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/metrics_tests.cpp 29ed0330a498579896bbef3349572dd35299a40a
Diff: https://reviews.apache.org/r/38076/diff/
Testing
-------
Testing is done in the next review.
Thanks,
Joseph Wu
Re: Review Request 38076: [4/5] Integer Precision for JSON <->
Protobuf conversions.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38076/
-----------------------------------------------------------
(Updated Sept. 17, 2015, 12:14 p.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
Re-opening with fixes for g++ 4.8/4.9 on CentOS 7. (No changes other than rebase).
Bugs: MESOS-3345
https://issues.apache.org/jira/browse/MESOS-3345
Repository: mesos
Description
-------
Modify one libprocess test to match changes to JSON::Number.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/metrics_tests.cpp 29ed0330a498579896bbef3349572dd35299a40a
Diff: https://reviews.apache.org/r/38076/diff/
Testing
-------
Testing is done in the next review.
Thanks,
Joseph Wu
Re: Review Request 38076: [4/5] Integer Precision for JSON <->
Protobuf conversions.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38076/
-----------------------------------------------------------
(Updated Sept. 11, 2015, 10:42 a.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
Rebase due to test fix and merge conflict.
Bugs: MESOS-3345
https://issues.apache.org/jira/browse/MESOS-3345
Repository: mesos
Description
-------
Modify one libprocess test to match changes to JSON::Number.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/metrics_tests.cpp 29ed0330a498579896bbef3349572dd35299a40a
Diff: https://reviews.apache.org/r/38076/diff/
Testing
-------
Testing is done in the next review.
Thanks,
Joseph Wu
Re: Review Request 38076: [4/5] Integer Precision for JSON <->
Protobuf conversions.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38076/
-----------------------------------------------------------
(Updated Sept. 10, 2015, 11:25 a.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
Changes
-------
Update due to privatization of Number's fields.
Bugs: MESOS-3345
https://issues.apache.org/jira/browse/MESOS-3345
Repository: mesos
Description (updated)
-------
Modify one libprocess test to match changes to JSON::Number.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/metrics_tests.cpp 29ed0330a498579896bbef3349572dd35299a40a
Diff: https://reviews.apache.org/r/38076/diff/
Testing
-------
Testing is done in the next review.
Thanks,
Joseph Wu
Re: Review Request 38076: [4/5] Integer Precision for JSON <->
Protobuf conversions.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38076/#review98285
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Sept. 9, 2015, 10:20 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38076/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 10:20 p.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Modify one libprocess test which originally fetched an integer as a double.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/metrics_tests.cpp 29ed0330a498579896bbef3349572dd35299a40a
>
> Diff: https://reviews.apache.org/r/38076/diff/
>
>
> Testing
> -------
>
> Testing is done in the next review.
>
>
> Thanks,
>
> Joseph Wu
>
>