[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8000: Change FIOC_MMAP, FIOC_MUNMAP and FIOC_TRUNCATE into file operation c…

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on PR #8000:
URL: https://github.com/apache/nuttx/pull/8000#issuecomment-1368770047

   > Here I must disagree. You definitely need to change these, since they currently look like this:
   > 
   > ```
   > 
   >   NULL,                      /* write */
   >    NULL,                      /* seek */
   >    cxd56_adc_ioctl,           /* ioctl */
   >    NULL                       /* poll */
   >  #ifndef CONFIG_DISABLE_PSEUDOFS_OPERATIONS
   >    , NULL                     /* unlink */
   > #endif
   > ```
   > 
   > Not changing it would leave misleading comments (/* poll _/ is not the pointer to poll, /_ unlink */ is not a pointer to unlink etc.).
   > 
   > There are really just two options:
   > 
   > 1. delete all the trailing NULL pointers for all of these
   > 2. add the new functions in between.
   > 
   > I do the 2) because this preserves the current style
   
   Yes, that's why I prepare this patch: https://github.com/apache/nuttx/pull/8016 to remove the trailing NULL pointer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org