You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2013/04/29 09:32:27 UTC
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/
-----------------------------------------------------------
(Updated April 29, 2013, 7:32 a.m.)
Review request for oozie.
Summary (updated)
-----------------
OOZIE-1231 Provide access to launcher job URL from web console when using Map Reduce action
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1231
This addresses bug OOZIE-1231.
https://issues.apache.org/jira/browse/OOZIE-1231
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1470126
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1470126
trunk/core/src/main/java/org/apache/oozie/servlet/V11JobServlet.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1470126
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1470126
trunk/webapp/src/main/webapp/WEB-INF/web.xml 1470126
trunk/webapp/src/main/webapp/oozie-console.js 1470126
Diff: https://reviews.apache.org/r/10721/diff/
Testing
-------
locally tested using single node cluster.
DB upgrade test only on Derby, will do it on other DBs later.
Thanks,
Ryota Egashira
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
> On April 29, 2013, 6:39 p.m., Rohini Palaniswamy wrote:
> > trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java, line 319
> > <https://reviews.apache.org/r/10721/diff/2/?file=285663#file285663line319>
> >
> > This method is not required. Can be reverted
no it's required. map-reduce action is completed when child job is completed, not launcher, and we don't want to change the behavior.
> On April 29, 2013, 6:39 p.m., Rohini Palaniswamy wrote:
> > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java, line 44
> > <https://reviews.apache.org/r/10721/diff/2/?file=285665#file285665line44>
> >
> > Why public?
will fix
> On April 29, 2013, 6:39 p.m., Rohini Palaniswamy wrote:
> > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java, line 51
> > <https://reviews.apache.org/r/10721/diff/2/?file=285665#file285665line51>
> >
> > Small i
will fix
> On April 29, 2013, 6:39 p.m., Rohini Palaniswamy wrote:
> > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java, line 714
> > <https://reviews.apache.org/r/10721/diff/2/?file=285665#file285665line714>
> >
> > swapMRActionID()
will fix
- Ryota
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/#review19880
-----------------------------------------------------------
On April 29, 2013, 7:32 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10721/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 7:32 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> This addresses bug OOZIE-1231.
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1470126
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1470126
> trunk/core/src/main/java/org/apache/oozie/servlet/V11JobServlet.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1470126
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1470126
> trunk/webapp/src/main/webapp/WEB-INF/web.xml 1470126
> trunk/webapp/src/main/webapp/oozie-console.js 1470126
>
> Diff: https://reviews.apache.org/r/10721/diff/
>
>
> Testing
> -------
>
> locally tested using single node cluster.
> DB upgrade test only on Derby, will do it on other DBs later.
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/#review19880
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java
<https://reviews.apache.org/r/10721/#comment41016>
This method is not required. Can be reverted
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
<https://reviews.apache.org/r/10721/#comment41020>
Why public?
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
<https://reviews.apache.org/r/10721/#comment41017>
Small i
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
<https://reviews.apache.org/r/10721/#comment41019>
swapMRActionID()
- Rohini Palaniswamy
On April 29, 2013, 7:32 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10721/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 7:32 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> This addresses bug OOZIE-1231.
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1470126
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1470126
> trunk/core/src/main/java/org/apache/oozie/servlet/V11JobServlet.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1470126
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1470126
> trunk/webapp/src/main/webapp/WEB-INF/web.xml 1470126
> trunk/webapp/src/main/webapp/oozie-console.js 1470126
>
> Diff: https://reviews.apache.org/r/10721/diff/
>
>
> Testing
> -------
>
> locally tested using single node cluster.
> DB upgrade test only on Derby, will do it on other DBs later.
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/#review19975
-----------------------------------------------------------
Looks good.
I think we would need to update web services doc with the new v1.1 version.
trunk/webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/10721/#comment41191>
instead of having this function, can we change getOozieClientVersion() to return 1.1?
- Virag Kothari
On April 29, 2013, 7:04 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10721/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 7:04 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> This addresses bug OOZIE-1231.
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1470126
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1470126
> trunk/core/src/main/java/org/apache/oozie/servlet/V11JobServlet.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1470126
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1470126
> trunk/webapp/src/main/webapp/WEB-INF/web.xml 1470126
> trunk/webapp/src/main/webapp/oozie-console.js 1470126
>
> Diff: https://reviews.apache.org/r/10721/diff/
>
>
> Testing
> -------
>
> locally tested using single node cluster.
> DB upgrade test only on Derby, will do it on other DBs later.
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/#review20153
-----------------------------------------------------------
looks good
- Virag Kothari
On May 4, 2013, 12:55 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10721/
> -----------------------------------------------------------
>
> (Updated May 4, 2013, 12:55 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> This addresses bug OOZIE-1231.
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1479008
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1479008
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1479008
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1479008
> trunk/core/src/main/java/org/apache/oozie/servlet/V11JobServlet.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1479008
> trunk/core/src/main/java/org/apache/oozie/servlet/VersionServlet.java 1479008
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1479008
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1479008
> trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 1479008
> trunk/docs/src/site/twiki/WebServicesAPI.twiki 1479008
> trunk/webapp/src/main/webapp/WEB-INF/web.xml 1479008
> trunk/webapp/src/main/webapp/oozie-console.js 1479008
>
> Diff: https://reviews.apache.org/r/10721/diff/
>
>
> Testing
> -------
>
> locally tested using single node cluster.
> DB upgrade test only on Derby, will do it on other DBs later.
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/#review20243
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On May 7, 2013, 12:33 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10721/
> -----------------------------------------------------------
>
> (Updated May 7, 2013, 12:33 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> This addresses bug OOZIE-1231.
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1479725
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1479725
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1479725
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1479725
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1479725
> trunk/core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/VersionServlet.java 1479725
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1479725
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1479725
> trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 1479725
> trunk/docs/src/site/twiki/WebServicesAPI.twiki 1479725
> trunk/webapp/src/main/webapp/WEB-INF/web.xml 1479725
> trunk/webapp/src/main/webapp/oozie-console.js 1479725
>
> Diff: https://reviews.apache.org/r/10721/diff/
>
>
> Testing
> -------
>
> locally tested using single node cluster.
> DB upgrade test only on Derby, will do it on other DBs later.
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/
-----------------------------------------------------------
(Updated May 7, 2013, 12:33 a.m.)
Review request for oozie.
Changes
-------
sorry for spam. removed unused variable/import.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1231
This addresses bug OOZIE-1231.
https://issues.apache.org/jira/browse/OOZIE-1231
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1479725
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1479725
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1479725
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1479725
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1479725
trunk/core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/VersionServlet.java 1479725
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1479725
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1479725
trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 1479725
trunk/docs/src/site/twiki/WebServicesAPI.twiki 1479725
trunk/webapp/src/main/webapp/WEB-INF/web.xml 1479725
trunk/webapp/src/main/webapp/oozie-console.js 1479725
Diff: https://reviews.apache.org/r/10721/diff/
Testing
-------
locally tested using single node cluster.
DB upgrade test only on Derby, will do it on other DBs later.
Thanks,
Ryota Egashira
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/
-----------------------------------------------------------
(Updated May 7, 2013, 12:22 a.m.)
Review request for oozie.
Changes
-------
previous one missing v2jobservlet by mistake, adding it.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1231
This addresses bug OOZIE-1231.
https://issues.apache.org/jira/browse/OOZIE-1231
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1479725
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1479725
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1479725
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1479725
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1479725
trunk/core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/VersionServlet.java 1479725
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1479725
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1479725
trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 1479725
trunk/docs/src/site/twiki/WebServicesAPI.twiki 1479725
trunk/webapp/src/main/webapp/WEB-INF/web.xml 1479725
trunk/webapp/src/main/webapp/oozie-console.js 1479725
Diff: https://reviews.apache.org/r/10721/diff/
Testing
-------
locally tested using single node cluster.
DB upgrade test only on Derby, will do it on other DBs later.
Thanks,
Ryota Egashira
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/
-----------------------------------------------------------
(Updated May 7, 2013, 12:06 a.m.)
Review request for oozie.
Changes
-------
changed v1.1 to v2, since we will add SLA new api soon, and it become relatively major upgrade.
i ran this using single-node cluster setting again.
currently running all test cases. if no problem, this is final version.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1231
This addresses bug OOZIE-1231.
https://issues.apache.org/jira/browse/OOZIE-1231
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1479725
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1479725
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1479725
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1479725
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1479725
trunk/core/src/main/java/org/apache/oozie/servlet/VersionServlet.java 1479725
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1479725
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1479725
trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 1479725
trunk/docs/src/site/twiki/WebServicesAPI.twiki 1479725
trunk/webapp/src/main/webapp/WEB-INF/web.xml 1479725
trunk/webapp/src/main/webapp/oozie-console.js 1479725
Diff: https://reviews.apache.org/r/10721/diff/
Testing
-------
locally tested using single node cluster.
DB upgrade test only on Derby, will do it on other DBs later.
Thanks,
Ryota Egashira
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/
-----------------------------------------------------------
(Updated May 4, 2013, 12:55 a.m.)
Review request for oozie.
Changes
-------
changed OozieClient to use v1.1
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1231
This addresses bug OOZIE-1231.
https://issues.apache.org/jira/browse/OOZIE-1231
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1479008
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1479008
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1479008
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1479008
trunk/core/src/main/java/org/apache/oozie/servlet/V11JobServlet.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1479008
trunk/core/src/main/java/org/apache/oozie/servlet/VersionServlet.java 1479008
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1479008
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1479008
trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 1479008
trunk/docs/src/site/twiki/WebServicesAPI.twiki 1479008
trunk/webapp/src/main/webapp/WEB-INF/web.xml 1479008
trunk/webapp/src/main/webapp/oozie-console.js 1479008
Diff: https://reviews.apache.org/r/10721/diff/
Testing
-------
locally tested using single node cluster.
DB upgrade test only on Derby, will do it on other DBs later.
Thanks,
Ryota Egashira
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/
-----------------------------------------------------------
(Updated May 3, 2013, 6:55 p.m.)
Review request for oozie.
Changes
-------
version that fixed failed test case. some of Virag's comment might have been fixed, but now checking
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1231
This addresses bug OOZIE-1231.
https://issues.apache.org/jira/browse/OOZIE-1231
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1477887
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1477887
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1477887
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java 1477887
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1477887
trunk/core/src/main/java/org/apache/oozie/servlet/VersionServlet.java 1477887
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1477887
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1477887
trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 1477887
trunk/docs/src/site/twiki/WebServicesAPI.twiki 1477887
trunk/webapp/src/main/webapp/WEB-INF/web.xml 1477887
trunk/webapp/src/main/webapp/oozie-console.js 1477887
Diff: https://reviews.apache.org/r/10721/diff/
Testing
-------
locally tested using single node cluster.
DB upgrade test only on Derby, will do it on other DBs later.
Thanks,
Ryota Egashira
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/#review20024
-----------------------------------------------------------
Ship it!
Ship It!
- Virag Kothari
On May 1, 2013, 8:14 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10721/
> -----------------------------------------------------------
>
> (Updated May 1, 2013, 8:14 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> This addresses bug OOZIE-1231.
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1477887
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1477887
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1477887
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1477887
> trunk/core/src/main/java/org/apache/oozie/servlet/VersionServlet.java 1477887
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1477887
> trunk/docs/src/site/twiki/WebServicesAPI.twiki 1477887
> trunk/webapp/src/main/webapp/WEB-INF/web.xml 1477887
> trunk/webapp/src/main/webapp/oozie-console.js 1477887
>
> Diff: https://reviews.apache.org/r/10721/diff/
>
>
> Testing
> -------
>
> locally tested using single node cluster.
> DB upgrade test only on Derby, will do it on other DBs later.
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/#review20131
-----------------------------------------------------------
Sorry for the late comment
I think you need to add the new version v1.1 in VersionServlet and the OozieClient's validateWsVersion() should be modified a bit to handle it.
Otherwise the Java and CLI will default to using v1.
- Virag Kothari
On May 1, 2013, 8:14 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10721/
> -----------------------------------------------------------
>
> (Updated May 1, 2013, 8:14 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> This addresses bug OOZIE-1231.
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1477887
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1477887
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1477887
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1477887
> trunk/core/src/main/java/org/apache/oozie/servlet/VersionServlet.java 1477887
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1477887
> trunk/docs/src/site/twiki/WebServicesAPI.twiki 1477887
> trunk/webapp/src/main/webapp/WEB-INF/web.xml 1477887
> trunk/webapp/src/main/webapp/oozie-console.js 1477887
>
> Diff: https://reviews.apache.org/r/10721/diff/
>
>
> Testing
> -------
>
> locally tested using single node cluster.
> DB upgrade test only on Derby, will do it on other DBs later.
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/
-----------------------------------------------------------
(Updated May 1, 2013, 8:14 p.m.)
Review request for oozie.
Changes
-------
rebased patch and fixed Virag's comments.
- changed web.xml such that v1.1/jobs, v1.1/admin also supported (simply using the same v1 servlet underneath)
- changed oozie-console.js which use v1.1 consistently.
- added description for v1.1 on twiki doc
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1231
This addresses bug OOZIE-1231.
https://issues.apache.org/jira/browse/OOZIE-1231
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java 1477887
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1477887
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1477887
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1477887
trunk/core/src/main/java/org/apache/oozie/servlet/VersionServlet.java 1477887
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1477887
trunk/docs/src/site/twiki/WebServicesAPI.twiki 1477887
trunk/webapp/src/main/webapp/WEB-INF/web.xml 1477887
trunk/webapp/src/main/webapp/oozie-console.js 1477887
Diff: https://reviews.apache.org/r/10721/diff/
Testing
-------
locally tested using single node cluster.
DB upgrade test only on Derby, will do it on other DBs later.
Thanks,
Ryota Egashira
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
> On April 29, 2013, 7:08 p.m., Robert Kanter wrote:
> > trunk/core/src/main/java/org/apache/oozie/servlet/V11JobServlet.java, line 32
> > <https://reviews.apache.org/r/10721/diff/3/?file=285855#file285855line32>
> >
> > This is probably a silly question so feel free to ignore it, but what happens if we eventually get to a version 11? We won't be able to name it V11JobServlet because 1.1 is using that.
yes, valid point, I also thought of the same, simply hesitated to use dash or underscore considering class naming convention.. ok to use them?
- Ryota
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/#review19886
-----------------------------------------------------------
On April 29, 2013, 7:04 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10721/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 7:04 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> This addresses bug OOZIE-1231.
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1470126
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1470126
> trunk/core/src/main/java/org/apache/oozie/servlet/V11JobServlet.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1470126
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1470126
> trunk/webapp/src/main/webapp/WEB-INF/web.xml 1470126
> trunk/webapp/src/main/webapp/oozie-console.js 1470126
>
> Diff: https://reviews.apache.org/r/10721/diff/
>
>
> Testing
> -------
>
> locally tested using single node cluster.
> DB upgrade test only on Derby, will do it on other DBs later.
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Robert Kanter <rk...@cloudera.com>.
> On April 29, 2013, 7:08 p.m., Robert Kanter wrote:
> > trunk/core/src/main/java/org/apache/oozie/servlet/V11JobServlet.java, line 32
> > <https://reviews.apache.org/r/10721/diff/3/?file=285855#file285855line32>
> >
> > This is probably a silly question so feel free to ignore it, but what happens if we eventually get to a version 11? We won't be able to name it V11JobServlet because 1.1 is using that.
>
> Ryota Egashira wrote:
> yes, valid point, I also thought of the same, simply hesitated to use dash or underscore considering class naming convention.. ok to use them?
I'm now thinking 11 for 1.1 is probably fine. I imagine that by the time we get to version 11, we'll have long since removed version 1.1; otherwise we'd be supporting 11+ versions of the API at the same time, and that sounds like a nightmare.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/#review19886
-----------------------------------------------------------
On April 29, 2013, 7:04 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10721/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 7:04 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> This addresses bug OOZIE-1231.
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1470126
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1470126
> trunk/core/src/main/java/org/apache/oozie/servlet/V11JobServlet.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1470126
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1470126
> trunk/webapp/src/main/webapp/WEB-INF/web.xml 1470126
> trunk/webapp/src/main/webapp/oozie-console.js 1470126
>
> Diff: https://reviews.apache.org/r/10721/diff/
>
>
> Testing
> -------
>
> locally tested using single node cluster.
> DB upgrade test only on Derby, will do it on other DBs later.
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
> On April 29, 2013, 7:08 p.m., Robert Kanter wrote:
> > trunk/core/src/main/java/org/apache/oozie/servlet/V11JobServlet.java, line 32
> > <https://reviews.apache.org/r/10721/diff/3/?file=285855#file285855line32>
> >
> > This is probably a silly question so feel free to ignore it, but what happens if we eventually get to a version 11? We won't be able to name it V11JobServlet because 1.1 is using that.
>
> Ryota Egashira wrote:
> yes, valid point, I also thought of the same, simply hesitated to use dash or underscore considering class naming convention.. ok to use them?
>
> Robert Kanter wrote:
> I'm now thinking 11 for 1.1 is probably fine. I imagine that by the time we get to version 11, we'll have long since removed version 1.1; otherwise we'd be supporting 11+ versions of the API at the same time, and that sounds like a nightmare.
agree. thanks for input.
- Ryota
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/#review19886
-----------------------------------------------------------
On April 29, 2013, 7:04 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10721/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 7:04 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> This addresses bug OOZIE-1231.
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1470126
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1470126
> trunk/core/src/main/java/org/apache/oozie/servlet/V11JobServlet.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1470126
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1470126
> trunk/webapp/src/main/webapp/WEB-INF/web.xml 1470126
> trunk/webapp/src/main/webapp/oozie-console.js 1470126
>
> Diff: https://reviews.apache.org/r/10721/diff/
>
>
> Testing
> -------
>
> locally tested using single node cluster.
> DB upgrade test only on Derby, will do it on other DBs later.
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/#review19886
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/servlet/V11JobServlet.java
<https://reviews.apache.org/r/10721/#comment41031>
This is probably a silly question so feel free to ignore it, but what happens if we eventually get to a version 11? We won't be able to name it V11JobServlet because 1.1 is using that.
- Robert Kanter
On April 29, 2013, 7:04 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10721/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 7:04 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> This addresses bug OOZIE-1231.
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1470126
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1470126
> trunk/core/src/main/java/org/apache/oozie/servlet/V11JobServlet.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1470126
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1470126
> trunk/webapp/src/main/webapp/WEB-INF/web.xml 1470126
> trunk/webapp/src/main/webapp/oozie-console.js 1470126
>
> Diff: https://reviews.apache.org/r/10721/diff/
>
>
> Testing
> -------
>
> locally tested using single node cluster.
> DB upgrade test only on Derby, will do it on other DBs later.
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/#review19895
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On April 29, 2013, 7:04 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10721/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 7:04 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> This addresses bug OOZIE-1231.
> https://issues.apache.org/jira/browse/OOZIE-1231
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1470126
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1470126
> trunk/core/src/main/java/org/apache/oozie/servlet/V11JobServlet.java PRE-CREATION
> trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1470126
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1470126
> trunk/webapp/src/main/webapp/WEB-INF/web.xml 1470126
> trunk/webapp/src/main/webapp/oozie-console.js 1470126
>
> Diff: https://reviews.apache.org/r/10721/diff/
>
>
> Testing
> -------
>
> locally tested using single node cluster.
> DB upgrade test only on Derby, will do it on other DBs later.
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: OOZIE-1231 Provide access to launcher job URL from web
console when using Map Reduce action
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10721/
-----------------------------------------------------------
(Updated April 29, 2013, 7:04 p.m.)
Review request for oozie.
Changes
-------
fixed comments.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1231
This addresses bug OOZIE-1231.
https://issues.apache.org/jira/browse/OOZIE-1231
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1470126
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1470126
trunk/core/src/main/java/org/apache/oozie/servlet/V11JobServlet.java PRE-CREATION
trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1470126
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1470126
trunk/webapp/src/main/webapp/WEB-INF/web.xml 1470126
trunk/webapp/src/main/webapp/oozie-console.js 1470126
Diff: https://reviews.apache.org/r/10721/diff/
Testing
-------
locally tested using single node cluster.
DB upgrade test only on Derby, will do it on other DBs later.
Thanks,
Ryota Egashira