You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by cs...@apache.org on 2023/09/15 11:30:03 UTC

[impala] 01/02: IMPALA-12383: (Addendum) Use named params

This is an automated email from the ASF dual-hosted git repository.

csringhofer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 49a0445b5efe15992161144c33805055199c9969
Author: Michael Smith <mi...@cloudera.com>
AuthorDate: Thu Sep 14 12:12:32 2023 -0700

    IMPALA-12383: (Addendum) Use named params
    
    Updates the call to add_test_dimensions to pass named parameters to
    avoid any issues that might come up if additional parameters are added.
    
    Change-Id: Ief492d054abbd00338e27ded9988141db750707c
    Reviewed-on: http://gerrit.cloudera.org:8080/20483
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Michael Smith <mi...@cloudera.com>
---
 tests/query_test/test_aggregation.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/query_test/test_aggregation.py b/tests/query_test/test_aggregation.py
index 2e20abe7e..c7498ec06 100644
--- a/tests/query_test/test_aggregation.py
+++ b/tests/query_test/test_aggregation.py
@@ -92,7 +92,7 @@ class TestAggregation(ImpalaTestSuite):
 
   @classmethod
   def add_test_dimensions(cls):
-    super(TestAggregation, cls).add_test_dimensions(ALL_CLUSTER_SIZES)
+    super(TestAggregation, cls).add_test_dimensions(cluster_sizes=ALL_CLUSTER_SIZES)
 
     # Add two more dimensions
     cls.ImpalaTestMatrix.add_dimension(ImpalaTestDimension('agg_func', *AGG_FUNCTIONS))