You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by egorklimov <gi...@git.apache.org> on 2018/08/06 13:41:40 UTC
[GitHub] zeppelin pull request #3111: testCronDisable fixed
GitHub user egorklimov opened a pull request:
https://github.com/apache/zeppelin/pull/3111
testCronDisable fixed
### What is this PR for?
`testCronDisable` in `ZeppelinRestApiTest` produce error:
```
09:15:51,001 ERROR org.quartz.core.ErrorLogger:2425 - Job (note.2DPJCQJGP threw an exception.
org.quartz.SchedulerException: Job threw an unhandled exception. [See nested exception: java.lang.NullPointerException]
at org.quartz.core.JobRunShell.run(JobRunShell.java:213)
at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:573)
Caused by: java.lang.NullPointerException
at org.apache.zeppelin.notebook.Notebook$CronJob.execute(Notebook.java:925)
at org.quartz.core.JobRunShell.run(JobRunShell.java:202)
... 1 more
```
Because cron job is not removed
### What type of PR is it?
Bug Fix
### What is the Jira issue?
* issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-3684
### How should this be tested?
* Tested manually
* CI pass
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3684
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3111.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3111
----
commit 5abd8fbec740f9f6ba1ec060c44eba60098075a4
Author: egorklimov <kl...@...>
Date: 2018-08-06T11:39:25Z
testCronDisable fixed
----
---
[GitHub] zeppelin issue #3111: [ZEPPELIN-3684] Remove cron job in ZeppelinRestApiTest...
Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:
https://github.com/apache/zeppelin/pull/3111
@zjffdu Look again please.
---
[GitHub] zeppelin issue #3111: [ZEPPELIN-3684] Remove cron job in ZeppelinRestApiTest...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3111
LGTM
---
[GitHub] zeppelin issue #3111: [ZEPPELIN-3684] Remove cron job in ZeppelinRestApiTest...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3111
@egorklimov Did you configure travis ?
---
[GitHub] zeppelin pull request #3111: [ZEPPELIN-3684] Remove cron job in ZeppelinRest...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3111
---
[GitHub] zeppelin issue #3111: [ZEPPELIN-3684] Remove cron job in ZeppelinRestApiTest...
Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:
https://github.com/apache/zeppelin/pull/3111
@zjffdu Yes I did, CI pass: https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/412604637
---