You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/12/23 02:24:51 UTC
[kudu-CR](branch-1.2.x) KUDU-1812. Redact calls to Slice::ToDebugString
Dan Burkert has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5576
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
......................................................................
KUDU-1812. Redact calls to Slice::ToDebugString
The Slice::ToDebugString method is used pervasively to log errors in the
case of malformed inputs, which almost always can contain sensitive user
data. Unfortunately Slice::ToDebugString is part of our public client
API, so the redaction can not be done centrally in ToDebugString itself.
Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Reviewed-on: http://gerrit.cloudera.org:8080/5568
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit a5a33b3ac8c8729d5dd5b790ba490720fba0b6de)
---
M src/kudu/cfile/binary_prefix_block.cc
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/compression_codec.cc
M src/kudu/common/encoded_key.cc
M src/kudu/common/key_encoder.h
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/row_changelist.cc
M src/kudu/consensus/log_util.cc
M src/kudu/rpc/serialization.cc
M src/kudu/rpc/transfer.cc
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/lock_manager.cc
M src/kudu/tablet/rowset_info.cc
M src/kudu/util/slice.cc
21 files changed, 118 insertions(+), 80 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/5576/1
--
To view, visit http://gerrit.cloudera.org:8080/5576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
[kudu-CR](branch-1.2.x) KUDU-1812. Redact calls to Slice::ToDebugString
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR](branch-1.2.x) KUDU-1812. Redact calls to Slice::ToDebugString
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
......................................................................
KUDU-1812. Redact calls to Slice::ToDebugString
The Slice::ToDebugString method is used pervasively to log errors in the
case of malformed inputs, which almost always can contain sensitive user
data. Unfortunately Slice::ToDebugString is part of our public client
API, so the redaction can not be done centrally in ToDebugString itself.
Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Reviewed-on: http://gerrit.cloudera.org:8080/5568
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit a5a33b3ac8c8729d5dd5b790ba490720fba0b6de)
Reviewed-on: http://gerrit.cloudera.org:8080/5576
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/cfile/binary_prefix_block.cc
M src/kudu/cfile/block_compression.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/compression_codec.cc
M src/kudu/common/encoded_key.cc
M src/kudu/common/key_encoder.h
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/row_changelist.cc
M src/kudu/consensus/log_util.cc
M src/kudu/rpc/serialization.cc
M src/kudu/rpc/transfer.cc
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/concurrent_btree.h
M src/kudu/tablet/delta_key.h
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/lock_manager.cc
M src/kudu/tablet/rowset_info.cc
M src/kudu/util/slice.cc
21 files changed, 118 insertions(+), 80 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d1ebde79dea5cae89956b70d13f67fbc6972034
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins