You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by jaydoane <gi...@git.apache.org> on 2015/11/22 20:13:47 UTC
[GitHub] couchdb-couch pull request: 2898 improve global changes tests
GitHub user jaydoane opened a pull request:
https://github.com/apache/couchdb-couch/pull/129
2898 improve global changes tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch 2898-improve-global-changes-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/129.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #129
----
commit c7ecd2b46601ce83177be333252f7a62aa5277ff
Author: Jay Doane <ja...@gmail.com>
Date: 2015-11-22T18:56:44Z
Create and delete test db using HTTP API
This supports downstream name munging that might occur
COUCHDB-2898
commit 5df95158d00bb0a72f62b13d9468dd47e5c6b95d
Author: Jay Doane <ja...@gmail.com>
Date: 2015-11-22T19:01:04Z
Ensure _global_changes exists
Downstream builds automatically ensure _global_changes exists, so this commit works for both cases
COUCHDB-2898
commit e7b3ba4319367cbe26838491d730fc9dc27be1a0
Author: Jay Doane <ja...@gmail.com>
Date: 2015-11-22T19:07:18Z
Replace "/" in db name with "-"
Unfortunately, the slash causes certain downstream builds to generate incorrect db_names in the _db_updates results.
This change still demonstrates that some non-alphanumeric characters are allowed in db names, while removing the
specific character that triggers downstream incompatibility.
COUCHDB-2898
commit a2e6dc919f3bd79efc4e423fc039f393b0240206
Author: Jay Doane <ja...@gmail.com>
Date: 2015-11-22T19:09:29Z
Simplify, and remove unnecessary code
COUCHDB-2898
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 2898 improve global changes tests
Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on the pull request:
https://github.com/apache/couchdb-couch/pull/129#issuecomment-158808269
@kxepal, I've removed the offending commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 2898 improve global changes tests
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/129#issuecomment-158801429
I think you should omit that commit in order to not forget about the bug and fix it in downstream (: There is no better reminder as build failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 2898 improve global changes tests
Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on the pull request:
https://github.com/apache/couchdb-couch/pull/129#issuecomment-158799592
Yes, it's possible that there's a bug downstream that's triggered by the "/" in the db name. It works correctly for one of the downstream builds, but fails in the other. @kxepal, if you prefer, I can omit that commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 2898 improve global changes tests
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/129#issuecomment-159398061
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 2898 improve global changes tests
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/129
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 2898 improve global changes tests
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/129#issuecomment-158793662
Don't you actually hide an issue with e7b3ba4 commit? Slash character is used by global_changes for specific logic owner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---