You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2019/05/08 15:42:44 UTC
[Impala-ASF-CR] IMPALA-8524: Avoid calling "hive" via command line in EE tests
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13282
Change subject: IMPALA-8524: Avoid calling "hive" via command line in EE tests
......................................................................
IMPALA-8524: Avoid calling "hive" via command line in EE tests
"hive -e SQL..." without further parameters no longer works
when USE_CDP_HIVE=true (it doesn't establish a connection).
Some tests used this to load data.
These calls can be replaced with ImpalaTestSuite.run_stmt_in_hive()
which seems like a good idea regardless of the Hive 3 efforts.
Testing:
- ran the related tests (some run only in exhustive mode)
Change-Id: I874ac344ffd176ffd7b8540d57126a7026f4c4f6
---
M tests/custom_cluster/test_parquet_max_page_header.py
M tests/metadata/test_compute_stats.py
M tests/query_test/test_compressed_formats.py
3 files changed, 4 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/13282/1
--
To view, visit http://gerrit.cloudera.org:8080/13282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I874ac344ffd176ffd7b8540d57126a7026f4c4f6
Gerrit-Change-Number: 13282
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-8524: Avoid calling "hive" via command line in EE tests
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13282 )
Change subject: IMPALA-8524: Avoid calling "hive" via command line in EE tests
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I874ac344ffd176ffd7b8540d57126a7026f4c4f6
Gerrit-Change-Number: 13282
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 May 2019 17:14:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8524: Avoid calling "hive" via command line in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13282 )
Change subject: IMPALA-8524: Avoid calling "hive" via command line in EE tests
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I874ac344ffd176ffd7b8540d57126a7026f4c4f6
Gerrit-Change-Number: 13282
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 May 2019 22:25:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8524: Avoid calling "hive" via command line in EE tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13282 )
Change subject: IMPALA-8524: Avoid calling "hive" via command line in EE tests
......................................................................
IMPALA-8524: Avoid calling "hive" via command line in EE tests
"hive -e SQL..." without further parameters no longer works
when USE_CDP_HIVE=true (it doesn't establish a connection).
Some tests used this to load data.
These calls can be replaced with ImpalaTestSuite.run_stmt_in_hive()
which seems like a good idea regardless of the Hive 3 efforts.
Testing:
- ran the related tests (some run only in exhustive mode)
Change-Id: I874ac344ffd176ffd7b8540d57126a7026f4c4f6
Reviewed-on: http://gerrit.cloudera.org:8080/13282
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
---
M tests/custom_cluster/test_parquet_max_page_header.py
M tests/metadata/test_compute_stats.py
M tests/query_test/test_compressed_formats.py
3 files changed, 4 insertions(+), 5 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Csaba Ringhofer: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I874ac344ffd176ffd7b8540d57126a7026f4c4f6
Gerrit-Change-Number: 13282
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
[Impala-ASF-CR] IMPALA-8524: Avoid calling "hive" via command line in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13282 )
Change subject: IMPALA-8524: Avoid calling "hive" via command line in EE tests
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4187/
--
To view, visit http://gerrit.cloudera.org:8080/13282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I874ac344ffd176ffd7b8540d57126a7026f4c4f6
Gerrit-Change-Number: 13282
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 May 2019 21:20:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8524: Avoid calling "hive" via command line in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13282 )
Change subject: IMPALA-8524: Avoid calling "hive" via command line in EE tests
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4195/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I874ac344ffd176ffd7b8540d57126a7026f4c4f6
Gerrit-Change-Number: 13282
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 May 2019 22:25:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8524: Avoid calling "hive" via command line in EE tests
Posted by "Yongzhi Chen (Code Review)" <ge...@cloudera.org>.
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/13282 )
Change subject: IMPALA-8524: Avoid calling "hive" via command line in EE tests
......................................................................
Patch Set 1: Code-Review+1
Hive Cli is deprecated. Use beeline is a good idea.
--
To view, visit http://gerrit.cloudera.org:8080/13282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I874ac344ffd176ffd7b8540d57126a7026f4c4f6
Gerrit-Change-Number: 13282
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 May 2019 17:12:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8524: Avoid calling "hive" via command line in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13282 )
Change subject: IMPALA-8524: Avoid calling "hive" via command line in EE tests
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4224/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I874ac344ffd176ffd7b8540d57126a7026f4c4f6
Gerrit-Change-Number: 13282
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 May 2019 13:14:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8524: Avoid calling "hive" via command line in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13282 )
Change subject: IMPALA-8524: Avoid calling "hive" via command line in EE tests
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4195/
--
To view, visit http://gerrit.cloudera.org:8080/13282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I874ac344ffd176ffd7b8540d57126a7026f4c4f6
Gerrit-Change-Number: 13282
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 May 2019 01:06:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8524: Avoid calling "hive" via command line in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13282 )
Change subject: IMPALA-8524: Avoid calling "hive" via command line in EE tests
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4187/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I874ac344ffd176ffd7b8540d57126a7026f4c4f6
Gerrit-Change-Number: 13282
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 May 2019 17:18:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8524: Avoid calling "hive" via command line in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13282 )
Change subject: IMPALA-8524: Avoid calling "hive" via command line in EE tests
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/3122/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/13282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I874ac344ffd176ffd7b8540d57126a7026f4c4f6
Gerrit-Change-Number: 13282
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 May 2019 18:52:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8524: Avoid calling "hive" via command line in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13282 )
Change subject: IMPALA-8524: Avoid calling "hive" via command line in EE tests
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I874ac344ffd176ffd7b8540d57126a7026f4c4f6
Gerrit-Change-Number: 13282
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 May 2019 18:47:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8524: Avoid calling "hive" via command line in EE tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13282 )
Change subject: IMPALA-8524: Avoid calling "hive" via command line in EE tests
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13282
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I874ac344ffd176ffd7b8540d57126a7026f4c4f6
Gerrit-Change-Number: 13282
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 May 2019 18:51:02 +0000
Gerrit-HasComments: No