[jira] [Comment Edited] (THRIFT-2414) c_glib fix several bug.

["Jaesang Kim (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944778#comment-13944778 ] 

Jaesang Kim edited comment on THRIFT-2414 at 3/25/14 9:15 AM:
--------------------------------------------------------------

I deleted the code to set SO_LINGER option.


was (Author: hsleep):
delete code to set SO_LINGER option

> c_glib fix several bug.
> -----------------------
>
>                 Key: THRIFT-2414
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2414
>             Project: Thrift
>          Issue Type: Bug
>          Components: C glib - Compiler, C glib - Library
>    Affects Versions: 0.7, 0.8
>            Reporter: Jaesang Kim
>             Fix For: 0.9
>
>         Attachments: thrift-2414-c_glib-bug-fix.patch, thrift-2414-c_glib-bug-fix.patch
>
>
> 1. leaks in binary string
> thrift generate the "binary" type to GByteArray pointer. GByteArray must be freed with g_byte_array_unref().
> 2. not use *_array_free
> use *_array_unref function for the code readability
> 3. leaks in ThriftApplicationException class
> ThriftApplicationException class has no finalize function. To free a message attribute in ThriftApplicationException object, attach finalize function.
> 4. handle a error in thrift_buffered_transport_read_slow()
> if read function return a value less than zero, stop read and return.
> 5. use gethostbyname_r() function instead of gethostbyname()
> thrift client for parallel access. change to reentrant function.
> -6. use SO_LINGER for daemon application-
> -set thrift client socket's SO_LINGER option to {1, 0). for daemon application.-



--
This message was sent by Atlassian JIRA
(v6.2#6252)