You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "wangsheng (Code Review)" <ge...@cloudera.org> on 2019/12/11 06:14:34 UTC

[Impala-ASF-CR] IMPALA-8974: Fixed a bug when create kudu managed table without HMS config

Hello Quanlong Huang, Hao Hao, Tim Armstrong, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14398

to look at the new patch set (#15).

Change subject: IMPALA-8974: Fixed a bug when create kudu managed table without HMS config
......................................................................

IMPALA-8974: Fixed a bug when create kudu managed table without HMS
config

When catalogd connected to mysql/postgresql directly instead of
use HMS, a kudu managerd table created DDL would failed due to
Preconditions checked failed.

The patch fixed the bug by using the if condition instead of the
Preconditions functions which lead to exception when lack of HMS config.

Tests:
  * Add test for create/drop kudu managerd table without HMS config
  * Ran all front-end tests

Change-Id: Iacc53801a660c033869cb4747910c98a80e08297
---
M fe/src/main/java/org/apache/impala/catalog/KuduTable.java
A fe/src/test/java/org/apache/impala/catalog/CreateKuduTableWithoutHMSTest.java
M fe/src/test/resources/hive-site.xml.py
3 files changed, 148 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/14398/15
-- 
To view, visit http://gerrit.cloudera.org:8080/14398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iacc53801a660c033869cb4747910c98a80e08297
Gerrit-Change-Number: 14398
Gerrit-PatchSet: 15
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>