You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zach Amsden (Code Review)" <ge...@cloudera.org> on 2018/03/29 04:00:06 UTC
[Impala-ASF-CR] Revert "IMPALA-6389: Make '\0' delimited text files work"
Zach Amsden has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9851
Change subject: Revert "IMPALA-6389: Make '\0' delimited text files work"
......................................................................
Revert "IMPALA-6389: Make '\0' delimited text files work"
This reverts commit c2bdaf8af4cf35d3462595c2a341ed84dcf5d960.
An ASAN issue and potentially other problem have been found;
reverting to unbreak the build and tests.
Change-Id: If581311033de8c26e33316b19192c4579594f261
---
M be/src/exec/delimited-text-parser-test.cc
M be/src/exec/delimited-text-parser.cc
M be/src/exec/delimited-text-parser.h
M be/src/exec/delimited-text-parser.inline.h
M be/src/exec/hdfs-sequence-scanner.cc
M be/src/exec/hdfs-sequence-scanner.h
M be/src/exec/hdfs-text-scanner.cc
M be/src/exec/hdfs-text-scanner.h
8 files changed, 84 insertions(+), 169 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/9851/1
--
To view, visit http://gerrit.cloudera.org:8080/9851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If581311033de8c26e33316b19192c4579594f261
Gerrit-Change-Number: 9851
Gerrit-PatchSet: 1
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-6389: Make '\0' delimited text files work"
Posted by "Zach Amsden (Code Review)" <ge...@cloudera.org>.
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9851 )
Change subject: Revert "IMPALA-6389: Make '\0' delimited text files work"
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If581311033de8c26e33316b19192c4579594f261
Gerrit-Change-Number: 9851
Gerrit-PatchSet: 1
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Mar 2018 04:59:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-6389: Make '\0' delimited text files work"
Posted by "Zach Amsden (Code Review)" <ge...@cloudera.org>.
Zach Amsden has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9851 )
Change subject: Revert "IMPALA-6389: Make '\0' delimited text files work"
......................................................................
Revert "IMPALA-6389: Make '\0' delimited text files work"
This reverts commit c2bdaf8af4cf35d3462595c2a341ed84dcf5d960.
An ASAN issue and potentially other problem have been found;
reverting to unbreak the build and tests.
Change-Id: If581311033de8c26e33316b19192c4579594f261
Reviewed-on: http://gerrit.cloudera.org:8080/9851
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Zach Amsden <za...@cloudera.com>
---
M be/src/exec/delimited-text-parser-test.cc
M be/src/exec/delimited-text-parser.cc
M be/src/exec/delimited-text-parser.h
M be/src/exec/delimited-text-parser.inline.h
M be/src/exec/hdfs-sequence-scanner.cc
M be/src/exec/hdfs-sequence-scanner.h
M be/src/exec/hdfs-text-scanner.cc
M be/src/exec/hdfs-text-scanner.h
8 files changed, 84 insertions(+), 169 deletions(-)
Approvals:
Lars Volker: Looks good to me, approved
Zach Amsden: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If581311033de8c26e33316b19192c4579594f261
Gerrit-Change-Number: 9851
Gerrit-PatchSet: 2
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-6389: Make '\0' delimited text files work"
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9851 )
Change subject: Revert "IMPALA-6389: Make '\0' delimited text files work"
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If581311033de8c26e33316b19192c4579594f261
Gerrit-Change-Number: 9851
Gerrit-PatchSet: 1
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Comment-Date: Thu, 29 Mar 2018 04:02:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-6389: Make '\0' delimited text files work"
Posted by "Zach Amsden (Code Review)" <ge...@cloudera.org>.
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9851 )
Change subject: Revert "IMPALA-6389: Make '\0' delimited text files work"
......................................................................
Patch Set 2:
Strict revert; verified to fix build.
--
To view, visit http://gerrit.cloudera.org:8080/9851
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If581311033de8c26e33316b19192c4579594f261
Gerrit-Change-Number: 9851
Gerrit-PatchSet: 2
Gerrit-Owner: Zach Amsden <za...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Zach Amsden <za...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Mar 2018 05:00:27 +0000
Gerrit-HasComments: No