[GitHub] [beam] boyuanzz commented on a change in pull request #12926: [WIP] Clean up with_attributes from PubsubSource

[GitBox <gi...@apache.org>]

boyuanzz commented on a change in pull request #12926:
URL: https://github.com/apache/beam/pull/12926#discussion_r494724057



##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -1230,10 +1230,11 @@ def run_Read(self, transform_node, options):
       if transform.source.id_label:
         step.add_property(
             PropertyNames.PUBSUB_ID_LABEL, transform.source.id_label)
-      if transform.source.with_attributes:
-        # Setting this property signals Dataflow runner to return full
-        # PubsubMessages instead of just the data part of the payload.
-        step.add_property(PropertyNames.PUBSUB_SERIALIZED_ATTRIBUTES_FN, '')
+
+      # Setting this property signals Dataflow runner to return full
+      # PubsubMessages instead of just the data part of the payload.
+      step.add_property(PropertyNames.PUBSUB_SERIALIZED_ATTRIBUTES_FN, '')

Review comment:
       Hi Daniel, do you notice any performance variance between reading from pubsub with `with_attributes=True` and `with_attributes=False` when running on streaming service? @dpmills 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org