You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/05/06 22:28:18 UTC

[GitHub] [cordova-windows] janpio edited a comment on issue #270: description tag set to default instead of defined value - regression from 5.0.0

janpio edited a comment on issue #270: description tag set to default instead of defined value - regression from 5.0.0
URL: https://github.com/apache/cordova-windows/issues/270#issuecomment-489805286
 
 
   Reproduced.
   
   On changing `config.xml`'s description, `platforms/windows/config.xml` gets this diff:
   
   ```diff
   -   <name>HelloCordova</name>
       <description>
           A sample Apache Cordova application that responds to the deviceready event.
       </description>
   +   <name>HelloCordova</name>
   +   <description>
   +       Our new description.
   +   </description>
   ```
   
   and nothing else in the native project changes.
   
   ---
   
   I think this might be the method that is producing the platform config.xml:
   https://github.com/apache/cordova-windows/blob/c52b81c3f6daff69b57939fcf62451d3c2a602dd/template/cordova/lib/prepare.js#L693-L736
   Here something is going wrong with the defaults.xml.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org