[GitHub] sxjscience commented on a change in pull request #9495: bugfix for kAddTo in swap_axis

[GitBox <gi...@apache.org>]

sxjscience commented on a change in pull request #9495: bugfix for kAddTo in swap_axis
URL: https://github.com/apache/incubator-mxnet/pull/9495#discussion_r162699288
 
 

 ##########
 File path: src/operator/swapaxis-inl.h
 ##########
 @@ -218,6 +227,11 @@ class SwapAxisProp : public OperatorProperty {
     return {out_grad[swapaxisenum::kOut]};
   };
 
+  std::vector<ResourceRequest> BackwardResource(
+      const std::vector<TShape> &in_shape) const override {
+    return {ResourceRequest::kTempSpace};
+  }
+
   Operator* CreateOperator(Context ctx) const override {
     LOG(FATAL) << "Not Implemented";
     return NULL;
 
 Review comment:
   We should also revise the test (https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/test_operator.py#L361-L377).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services