You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Sijie Guo <gu...@gmail.com> on 2012/04/01 17:56:33 UTC
Review Request: BOOKKEEPER-203: improve ledger manager interface to remove
zookeeper dependency on metadata operations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4603/
-----------------------------------------------------------
Review request for bookkeeper.
Summary
-------
we need to improve ledger manager interface to remove zookeeper dependency on metadata operations, so it is easy for us to implement a MetaStore based ledger manager.
This addresses bug BOOKKEEPER-203.
https://issues.apache.org/jira/browse/BOOKKEEPER-203
Diffs
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ee38862
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java 2eed192
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java 17c70f1
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java 911c660
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java 490c130
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java b9cd624
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java f0a165f
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java 5b10a5b
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java e576792
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java 2dcf0e4
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java 56186ab
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java e1bd1ff
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java 8fd7df8
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java 1300974
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java b573181
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerLayout.java 3a3a81e
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 7d9eb96
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java b62ad3a
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ReflectionUtils.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerCacheTest.java 52cf514
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java 6135250
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestFencing.java c5350ad
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 12c1b5a
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalAsyncLedgerOpsTest.java 24b3c12
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieFailureTest.java 70a4ea9
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieReadWriteTest.java 7d97fd4
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieRecoveryTest.java d99156e
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalLedgerDeleteTest.java dbcd65a
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerLayoutTest.java 4784854
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java b8a541b
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerManager.java e07c756
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/AsyncLedgerOpsTest.java d7f153a
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java c172224
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java e647d68
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java 3a3c8af
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerDeleteTest.java 2d3593e
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerBaseTestCase.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerTestCase.java PRE-CREATION
Diff: https://reviews.apache.org/r/4603/diff
Testing
-------
Thanks,
Sijie
Re: Review Request: BOOKKEEPER-203: improve ledger manager interface to
remove zookeeper dependency on metadata operations.
Posted by Sijie Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4603/
-----------------------------------------------------------
(Updated June 18, 2012, 3:52 p.m.)
Review request for bookkeeper.
Changes
-------
rebase the patch to latest trunk
Description
-------
we need to improve ledger manager interface to remove zookeeper dependency on metadata operations, so it is easy for us to implement a MetaStore based ledger manager.
This addresses bug BOOKKEEPER-203.
https://issues.apache.org/jira/browse/BOOKKEEPER-203
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java eae08a3
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java f8fab4e
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java 7cb2479
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java c0b8121
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java 484a055
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java fd879ed
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java 8423de9
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java 8c5bce3
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java 5b10a5b
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java fd4ff03
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java c699eae
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java 101ebf3
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java e59d379
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java ce53461
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java 1300974
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java b573181
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerLayout.java cab02fe
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 7d9eb96
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java 491a3e4
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkVersion.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ReflectionUtils.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/versioning/Version.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/versioning/Versioned.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerCacheTest.java 3720bb8
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java 8bd3f6b
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestFencing.java 1c109a2
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 12c1b5a
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalAsyncLedgerOpsTest.java 24b3c12
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieFailureTest.java 70a4ea9
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieReadWriteTest.java 7d97fd4
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieRecoveryTest.java d99156e
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalLedgerDeleteTest.java dbcd65a
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerLayoutTest.java 4784854
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java b8a541b
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerManager.java e07c756
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestZkVersion.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/AsyncLedgerOpsTest.java d7f153a
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java a81067d
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java e647d68
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java 384cc3b
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerDeleteTest.java 2d3593e
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerMultiDigestTestCase.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerTestCase.java PRE-CREATION
Diff: https://reviews.apache.org/r/4603/diff/
Testing
-------
Thanks,
Sijie Guo
Re: Review Request: BOOKKEEPER-203: improve ledger manager interface to
remove zookeeper dependency on metadata operations.
Posted by Sijie Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4603/
-----------------------------------------------------------
(Updated June 18, 2012, 1:36 p.m.)
Review request for bookkeeper.
Changes
-------
attach a new patch renaming MultiLedgerManagerBaseTestCase to MultiLedgerManagerMultiDigestTestCase
Description
-------
we need to improve ledger manager interface to remove zookeeper dependency on metadata operations, so it is easy for us to implement a MetaStore based ledger manager.
This addresses bug BOOKKEEPER-203.
https://issues.apache.org/jira/browse/BOOKKEEPER-203
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java eae08a3
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java 139e1c3
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java 3c4f339
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java c0b8121
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java 484a055
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java fd879ed
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java 8423de9
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java 8c5bce3
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java 5b10a5b
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java fd4ff03
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java c699eae
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java 101ebf3
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java 2b5b21a
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java ce53461
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java 1300974
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java b573181
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerLayout.java cab02fe
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 7d9eb96
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java 491a3e4
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkVersion.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ReflectionUtils.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/versioning/Version.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/versioning/Versioned.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerCacheTest.java 3720bb8
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java 8bd3f6b
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestFencing.java 1c109a2
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 12c1b5a
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalAsyncLedgerOpsTest.java 24b3c12
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieFailureTest.java 70a4ea9
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieReadWriteTest.java 7d97fd4
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieRecoveryTest.java d99156e
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalLedgerDeleteTest.java dbcd65a
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerLayoutTest.java 4784854
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java b8a541b
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerManager.java e07c756
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestZkVersion.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/AsyncLedgerOpsTest.java d7f153a
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java a81067d
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java e647d68
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java 384cc3b
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerDeleteTest.java 2d3593e
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerMultiDigestTestCase.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerTestCase.java PRE-CREATION
Diff: https://reviews.apache.org/r/4603/diff/
Testing
-------
Thanks,
Sijie Guo
Re: Review Request: BOOKKEEPER-203: improve ledger manager interface to
remove zookeeper dependency on metadata operations.
Posted by Sijie Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4603/
-----------------------------------------------------------
(Updated June 18, 2012, 6:09 a.m.)
Review request for bookkeeper.
Changes
-------
update new patch addressing Ivan's comments.
1) rebased to latest trunk
2) remove unused MetaStoreException and setClass in ReflectionUtils
3) improve LedgerManagerFactory#newLedgerManagerFactory for backward compatibility.
4) add uninitialize in LedgerManagerFactory to release resources used by ledger manager factory.
Description
-------
we need to improve ledger manager interface to remove zookeeper dependency on metadata operations, so it is easy for us to implement a MetaStore based ledger manager.
This addresses bug BOOKKEEPER-203.
https://issues.apache.org/jira/browse/BOOKKEEPER-203
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java eae08a3
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java 139e1c3
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java 3c4f339
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java c0b8121
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java 484a055
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java fd879ed
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java 8423de9
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java 8c5bce3
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java 5b10a5b
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java fd4ff03
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java c699eae
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java 101ebf3
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java 2b5b21a
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java ce53461
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java 1300974
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java b573181
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerLayout.java cab02fe
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 7d9eb96
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java 491a3e4
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ZkVersion.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ReflectionUtils.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/versioning/Version.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/versioning/Versioned.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerCacheTest.java 3720bb8
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java 8bd3f6b
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestFencing.java 1c109a2
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 12c1b5a
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalAsyncLedgerOpsTest.java 24b3c12
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieFailureTest.java 70a4ea9
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieReadWriteTest.java 7d97fd4
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieRecoveryTest.java d99156e
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalLedgerDeleteTest.java dbcd65a
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerLayoutTest.java 4784854
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java b8a541b
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerManager.java e07c756
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestZkVersion.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/AsyncLedgerOpsTest.java d7f153a
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java a81067d
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java e647d68
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java 384cc3b
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerDeleteTest.java 2d3593e
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerBaseTestCase.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerTestCase.java PRE-CREATION
Diff: https://reviews.apache.org/r/4603/diff/
Testing
-------
Thanks,
Sijie Guo
Re: Review Request: BOOKKEEPER-203: improve ledger manager interface to
remove zookeeper dependency on metadata operations.
Posted by Sijie Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4603/
-----------------------------------------------------------
(Updated 2012-05-31 10:02:56.012746)
Review request for bookkeeper.
Changes
-------
bring the patch to latest trunk
Summary
-------
we need to improve ledger manager interface to remove zookeeper dependency on metadata operations, so it is easy for us to implement a MetaStore based ledger manager.
This addresses bug BOOKKEEPER-203.
https://issues.apache.org/jira/browse/BOOKKEEPER-203
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java eae08a3
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java 139e1c3
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java 3c4f339
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java 4df689e
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java 484a055
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java f1bec89
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java 73fe7d4
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java 8c5bce3
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java 5b10a5b
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java fd4ff03
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java c699eae
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java 101ebf3
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java 2b5b21a
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java ce53461
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java 1300974
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java b573181
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerLayout.java cab02fe
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 7d9eb96
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java 491a3e4
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ReflectionUtils.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerCacheTest.java 52cf514
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java 8bd3f6b
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestFencing.java 1c109a2
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 12c1b5a
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalAsyncLedgerOpsTest.java 24b3c12
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieFailureTest.java 70a4ea9
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieReadWriteTest.java 7d97fd4
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieRecoveryTest.java d99156e
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalLedgerDeleteTest.java dbcd65a
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerLayoutTest.java 4784854
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java b8a541b
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerManager.java e07c756
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/AsyncLedgerOpsTest.java d7f153a
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java a81067d
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java e647d68
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java 384cc3b
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerDeleteTest.java 2d3593e
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerBaseTestCase.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerTestCase.java PRE-CREATION
Diff: https://reviews.apache.org/r/4603/diff
Testing
-------
Thanks,
Sijie
Re: Review Request: BOOKKEEPER-203: improve ledger manager interface to
remove zookeeper dependency on metadata operations.
Posted by Sijie Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4603/
-----------------------------------------------------------
(Updated 2012-05-13 02:44:58.032203)
Review request for bookkeeper.
Changes
-------
update a new patch, which brought the code to latest trunk and addressed Flavio's suggestions.
Summary
-------
we need to improve ledger manager interface to remove zookeeper dependency on metadata operations, so it is easy for us to implement a MetaStore based ledger manager.
This addresses bug BOOKKEEPER-203.
https://issues.apache.org/jira/browse/BOOKKEEPER-203
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java aa4dec2
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java 4dc71e5
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java c8b5001
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java 4df689e
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java 484a055
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java eb0955b
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java 712bbea
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java 8c5bce3
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java 5b10a5b
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java 6ce576d
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java c699eae
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java 101ebf3
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java e1bd1ff
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java ce53461
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java 1300974
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java b573181
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java PRE-CREATION
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerLayout.java cab02fe
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 7d9eb96
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java 491a3e4
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ReflectionUtils.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerCacheTest.java 52cf514
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java 8bd3f6b
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestFencing.java 1c109a2
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 12c1b5a
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalAsyncLedgerOpsTest.java 24b3c12
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieFailureTest.java 70a4ea9
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieReadWriteTest.java 7d97fd4
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieRecoveryTest.java d99156e
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalLedgerDeleteTest.java dbcd65a
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerLayoutTest.java 4784854
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java b8a541b
bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerManager.java e07c756
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/AsyncLedgerOpsTest.java d7f153a
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java a81067d
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java e647d68
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java 3a3c8af
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerDeleteTest.java 2d3593e
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerBaseTestCase.java PRE-CREATION
bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerTestCase.java PRE-CREATION
Diff: https://reviews.apache.org/r/4603/diff
Testing
-------
Thanks,
Sijie
Re: Review Request: BOOKKEEPER-203: improve ledger manager interface to
remove zookeeper dependency on metadata operations.
Posted by Sijie Guo <gu...@gmail.com>.
> On 2012-04-03 21:17:04, fpj wrote:
> > It looks pretty good for me, I just have a few small comments.
Thanks Flavio for reviewing it. I would like to bring the patch to latest trunk and update it with your comments.
> On 2012-04-03 21:17:04, fpj wrote:
> > bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java, line 178
> > <https://reviews.apache.org/r/4603/diff/1/?file=97866#file97866line178>
> >
> > It doesn't look like we need to make this call public. If it is for testing, we could simply use inheritance, no?
we use parseConfig in ledgermanager not for testing, which is another package.
> On 2012-04-03 21:17:04, fpj wrote:
> > bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java, line 146
> > <https://reviews.apache.org/r/4603/diff/1/?file=97868#file97868line146>
> >
> > I'm wondering if it is ok to have a reference specific to zk here. Is the idea here that for every new backend we add, we include required system properties here?
zkLedgersRootPath not only for zookeeper-based ledger manager to store ledger metadata. under zkLedgersRootPath there is a 'layout' znode, which describes the metadata layout and which ledger manager it used for current bookkeeper cluster.
> On 2012-04-03 21:17:04, fpj wrote:
> > bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java, line 30
> > <https://reviews.apache.org/r/4603/diff/1/?file=97870#file97870line30>
> >
> > I wonder if ActiveLedgerManager is a good name for this class. It doesn't indicate that it is related to the bookie side, and it might be good to refer to it. But, I don't feel too strongly about it, since the comment before the class says that it is for bookies.
I don't have a good name for it also, just used its original name before we abstracted ledger manager interface.
- Sijie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4603/#review6616
-----------------------------------------------------------
On 2012-04-01 15:56:33, Sijie Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4603/
> -----------------------------------------------------------
>
> (Updated 2012-04-01 15:56:33)
>
>
> Review request for bookkeeper.
>
>
> Summary
> -------
>
> we need to improve ledger manager interface to remove zookeeper dependency on metadata operations, so it is easy for us to implement a MetaStore based ledger manager.
>
>
> This addresses bug BOOKKEEPER-203.
> https://issues.apache.org/jira/browse/BOOKKEEPER-203
>
>
> Diffs
> -----
>
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ee38862
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java 2eed192
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java 17c70f1
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java 911c660
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java 490c130
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java b9cd624
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java f0a165f
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java 5b10a5b
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java e576792
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java 2dcf0e4
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java 56186ab
> bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java e1bd1ff
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java 8fd7df8
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java PRE-CREATION
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java 1300974
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java PRE-CREATION
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java b573181
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java PRE-CREATION
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerLayout.java 3a3a81e
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 7d9eb96
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java b62ad3a
> bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ReflectionUtils.java PRE-CREATION
> bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerCacheTest.java 52cf514
> bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java 6135250
> bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestFencing.java c5350ad
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 12c1b5a
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalAsyncLedgerOpsTest.java 24b3c12
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieFailureTest.java 70a4ea9
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieReadWriteTest.java 7d97fd4
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieRecoveryTest.java d99156e
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalLedgerDeleteTest.java dbcd65a
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerLayoutTest.java 4784854
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java b8a541b
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerManager.java e07c756
> bookkeeper-server/src/test/java/org/apache/bookkeeper/test/AsyncLedgerOpsTest.java d7f153a
> bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java c172224
> bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java e647d68
> bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java 3a3c8af
> bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerDeleteTest.java 2d3593e
> bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerBaseTestCase.java PRE-CREATION
> bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerTestCase.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/4603/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sijie
>
>
Re: Review Request: BOOKKEEPER-203: improve ledger manager interface to
remove zookeeper dependency on metadata operations.
Posted by fp...@apache.org.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4603/#review6616
-----------------------------------------------------------
It looks pretty good for me, I just have a few small comments.
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java
<https://reviews.apache.org/r/4603/#comment14294>
For clarity, can we rename it to MetaStoreException or MetadataStoreException?
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java
<https://reviews.apache.org/r/4603/#comment14397>
MetaStoreException
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java
<https://reviews.apache.org/r/4603/#comment14401>
It doesn't look like we need to make this call public. If it is for testing, we could simply use inheritance, no?
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
<https://reviews.apache.org/r/4603/#comment14404>
I'm wondering if it is ok to have a reference specific to zk here. Is the idea here that for every new backend we add, we include required system properties here?
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java
<https://reviews.apache.org/r/4603/#comment14417>
You may want to say bookie instead of server side.
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java
<https://reviews.apache.org/r/4603/#comment14416>
I wonder if ActiveLedgerManager is a good name for this class. It doesn't indicate that it is related to the bookie side, and it might be good to refer to it. But, I don't feel too strongly about it, since the comment before the class says that it is for bookies.
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java
<https://reviews.apache.org/r/4603/#comment14405>
The comment here should not refer to zk, right?
- fpj
On 2012-04-01 15:56:33, Sijie Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4603/
> -----------------------------------------------------------
>
> (Updated 2012-04-01 15:56:33)
>
>
> Review request for bookkeeper.
>
>
> Summary
> -------
>
> we need to improve ledger manager interface to remove zookeeper dependency on metadata operations, so it is easy for us to implement a MetaStore based ledger manager.
>
>
> This addresses bug BOOKKEEPER-203.
> https://issues.apache.org/jira/browse/BOOKKEEPER-203
>
>
> Diffs
> -----
>
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java ee38862
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java 2eed192
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java 17c70f1
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java 911c660
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java 490c130
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java b9cd624
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java f0a165f
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java 5b10a5b
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java e576792
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java 2dcf0e4
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java 56186ab
> bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java e1bd1ff
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java 8fd7df8
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java PRE-CREATION
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java 1300974
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java PRE-CREATION
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java b573181
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java PRE-CREATION
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerLayout.java 3a3a81e
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 7d9eb96
> bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java b62ad3a
> bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ReflectionUtils.java PRE-CREATION
> bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerCacheTest.java 52cf514
> bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieRecoveryTest.java 6135250
> bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestFencing.java c5350ad
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 12c1b5a
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalAsyncLedgerOpsTest.java 24b3c12
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieFailureTest.java 70a4ea9
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieReadWriteTest.java 7d97fd4
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalBookieRecoveryTest.java d99156e
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/HierarchicalLedgerDeleteTest.java dbcd65a
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerLayoutTest.java 4784854
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java b8a541b
> bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/TestLedgerManager.java e07c756
> bookkeeper-server/src/test/java/org/apache/bookkeeper/test/AsyncLedgerOpsTest.java d7f153a
> bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java c172224
> bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java e647d68
> bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java 3a3c8af
> bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerDeleteTest.java 2d3593e
> bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerBaseTestCase.java PRE-CREATION
> bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerTestCase.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/4603/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sijie
>
>